[#41885] - [5.1] resolve todo image filter
- Fixed in Code Base
- 6 Dec 2023
- Medium
- Build: 5.0-dev
- # 41885
- Diff
- brianteeman:21_resolve_todo_image_filter
User tests: Successful: Unsuccessful:
Remove check for resource when we only support PHP 8
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.0-dev
|
||
| Title |
|
||||||
I have tested this item ✅ successfully on 9fda474
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.
I have tested this item ✅ successfully on 9fda474
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41885.
| Labels |
Added:
?
PR-5.1-dev
Removed: PR-5.0-dev |
||
Hi @brianteeman I was wondering if it should be updated here as well:
https://github.com/brianteeman/joomla-cms/blob/50465cd7f18d27df0f4a421326872f9a9381fb19/installation/src/Model/ChecksModel.php#L199
afaict its a different thing but i could be wrong. I was just following the information in the todo notice
Thanks @brianteeman, Let's do an internal check and I'll update you
whichever you decide any changes to those files are beyond the scope of this PR and should be handled in their own pr as they are nothing to do with the title of this PR
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-12-06 18:35:48 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
RTC
Removed: ? |
||
Thank you @brianteeman !
This pull request has been automatically rebased to 5.1-dev.