NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Sep 2023

we test the style of scss files but not the style of css files

this pr adds the testing of the css files located in the build/media/source folder
this pr corrects most of the styling errors

The exceptions are for some files that will be removed (in another pr) and a few prefixed classes which asre excluded - not sure what to do with those?

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: unknown if it is needed or not?

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category Repository NPM Change
avatar brianteeman brianteeman - open - 23 Sep 2023
avatar brianteeman brianteeman - change - 23 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 23 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner
HLeithner - comment - 23 Sep 2023

can you please fix ci, I think I broke something while solving the merge conflict and some vendor prefixes make troubles

e7fa9a7 23 Sep 2023 avatar brianteeman lint
avatar brianteeman
brianteeman - comment - 23 Sep 2023

should be ok now

avatar brianteeman brianteeman - change - 23 Sep 2023
The description was changed
avatar brianteeman brianteeman - edited - 23 Sep 2023
avatar HLeithner HLeithner - close - 24 Sep 2023
avatar HLeithner HLeithner - merge - 24 Sep 2023
avatar HLeithner HLeithner - change - 24 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-24 08:28:27
Closed_By HLeithner
avatar brianteeman
brianteeman - comment - 24 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment