? Failure

User tests: Successful: Unsuccessful:

avatar mbabker
mbabker
28 Aug 2014

Updates references to no longer present JRegistry to the namespaced \Joomla\Registry\Registry

avatar mbabker mbabker - open - 28 Aug 2014
avatar jissues-bot jissues-bot - change - 28 Aug 2014
Status Pending New
Labels Added: ?
avatar Bakual
Bakual - comment - 28 Aug 2014

When I did #3823 I wondered if the leading slash is needed or not. Do you know?
Because I see you use no leading slash in the use Joomla\Registry\Registry; but have * @var \Joomla\Registry\Registry in some docblocks.
For my IDE it was fine without the leading one.

avatar beat
beat - comment - 28 Aug 2014

@Bakual In docblocks, leading \ is better and clearer. So you do not have to look up if the whole file or section is namespaced and know upfront that it's an absolute namespace.

That said (as just commented on the components PR), our php-doc docblocks for params and return, we should use RegistryInterface instead of Registry, since any alternate implementation that also implements RegistryInterface should be accepted/acceptable. And that's very important for a good implementation-independant framework imho.

avatar mbabker
mbabker - comment - 28 Aug 2014

When I did #3823 I wondered if the leading slash is needed or not. Do you know?
Because I see you use no leading slash in the use Joomla\Registry\Registry; but have * @var \Joomla\Registry\Registry in some docblocks.
For my IDE it was fine without the leading one.

Mostly personal preference and some clarity. When I'm in a fully namespaced environment, I consider anything without the preceding \ to reference a namespaced class that has a use statement and anything with the \ is the fully qualified class name.

avatar Bakual
Bakual - comment - 28 Aug 2014

Thanks for the explanation.

avatar brianteeman brianteeman - change - 28 Aug 2014
Status New Pending
avatar mbabker mbabker - reference | - 4 Sep 14
avatar dbhurley
dbhurley - comment - 4 Sep 2014

Merged into 3.4-dev.

avatar dbhurley dbhurley - change - 4 Sep 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-09-04 19:43:49
avatar dbhurley dbhurley - close - 4 Sep 2014
avatar dbhurley dbhurley - close - 4 Sep 2014
avatar roland-d roland-d - change - 16 Feb 2015
Milestone Added:
avatar mbabker mbabker - head_ref_deleted - 16 Feb 2015

Add a Comment

Login with GitHub to post a comment