Feeling Lucky
?
[#4187] - Update JRegistry references in installation, layouts, modules, and plugins folders
- Closed
- 4 Sep 2014
- Medium
- Build: staging
- # 4187
- Diff
- mbabker:InstallationRegistry
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Updates references to no longer present JRegistry to the namespaced \Joomla\Registry\Registry
jissues-bot
- | Status | Pending | ⇒ | New |
| Labels |
Added:
?
|
||
mbabker
- comment
- 28 Aug 2014
As we don't already have an existing interface (here or in the Framework), one would have to be defined first.
If there was anything that we wanted to do differently, my suggestion would be to loosen the coupling to \Joomla\Registry\Registry by refactoring the code to access that object as an array as it implements the ArrayAccess interface, then developers could either continue using the Registry object or use simple arrays (or theoretically anything implementing ArrayAccess).
brianteeman
- | Status | New | ⇒ | Pending |
dbhurley
- comment
- 4 Sep 2014
Merged into 3.4-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-04 19:44:03 |
roland-d
- | Milestone |
Added: |
||
Wouldn't this small (but extended) code-refactoring be the perfect timing to introduce \Joomla\Registry\RegistryInterface and make that the php-doc-block documented parameter for the uses of \Joomla\Registry\Registry instead of \Joomla\Registry\Registry ?
It could also set the right example for other namespacing refactorings. ;-)