User tests: Successful: Unsuccessful:
The select task view is the same as the select module view except it uses its own css file with invalid css.
This PR changes that so that it uses an scss file in exactly the same way as com_modules. This also removes the invalid css and makes it more maintainable. There will be no visible change
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org: will be added when merged
No documentation changes for manual.joomla.org needed
Category | ⇒ | Administration com_admin Repository NPM Change |
Status | New | ⇒ | Pending |
Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.
sorry - not sure exactly what you are asking for here
more or like a copy of that what the compat plugin does for the es5 assets. new json file with the removed parts from this pr and loading the new json file when the es5 assets are loaded
sorry I think I understand what you mean but I dont know what to put in place of the xxxxxxxxxxx
/**
* Load the es5 assets stubs, they are needed if an extension
* directly uses a core es5 asset which has no function in Joomla 5+
* and only provides an empty asset to not throw an exception
*/
if ($this->params->get('es5_assets', '1')) {
$event->getDocument()
->getWebAssetManager()
->getRegistry()
->addRegistryFile('media/plg_behaviour_compat/es5.asset.json');
}
/**
* Load the com_scheduler.admin-view-select-task-css stub asset, if an extension
* directly used it - very unlikely - to an asset which has no function in Joomla 5+
* and only provides an empty asset to not throw an exception
*/
if ($this->params->get('***************', '1')) {
$event->getDocument()
->getWebAssetManager()
->getRegistry()
->addRegistryFile('media/plg_behaviour_compat/**********.json');
}
Category | Administration com_admin Repository NPM Change | ⇒ | Administration com_admin com_banners com_content com_fields com_installer com_joomlaupdate com_menus com_modules com_templates com_users Language & Strings Modules |
Labels |
Added:
Feature
|
Category | Administration com_admin com_banners com_content com_fields com_installer com_joomlaupdate com_menus com_modules com_templates com_users Language & Strings Modules | ⇒ | Administration com_admin Repository NPM Change |
Labels |
Added:
Language Change
Removed: NPM Resource Changed |
@brianteeman Shall I help with the merge conflicts?
Labels |
Added:
NPM Resource Changed
Removed: Language Change |
@richard67 yes please - not in the right headspace today to resolve it
Any help with this would be appreciated as well #41871 (comment)
I think like this
@brianteeman Conflicts resolved. With the other thing I don't know yet if I can help.
thanks @richard67
@wilsonge yes I assumed that in my post just dont have a clue what to put in place of the xxxxxxxxxx in my code snippet
Create a new parameter in the plugin. Doesn't make sense to mix this with the existing es5 assets
thats what i am doing arent i? just need to know what to put instead of the xxxxxxxxxxx
/me confused
https://github.com/joomla/joomla-cms/blob/5.0-dev/plugins/behaviour/compat/compat.xml#L36-L47 new param in here to match and then pick a name. removed_assets
seems reasonable and we can polyfill any others into the same param rather than doing a param per asset.
Category | Administration com_admin Repository NPM Change | ⇒ | Administration com_admin Language & Strings Repository NPM Change Front End Plugins |
Labels |
Added:
Language Change
|
Hopefully I just got it right now. As soon as you mentioned the xml it started to click
Looks fine to me
Category | Administration com_admin Repository NPM Change Language & Strings Front End Plugins | ⇒ | Administration com_admin Language & Strings Repository NPM Change JavaScript Front End Plugins |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-30 20:26:13 |
Closed_By | ⇒ | HLeithner |
thanks
removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.