Feature Language Change NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Sep 2023

The select task view is the same as the select module view except it uses its own css file with invalid css.

This PR changes that so that it uses an scss file in exactly the same way as com_modules. This also removes the invalid css and makes it more maintainable. There will be no visible change

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: will be added when merged

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category Administration com_admin Repository NPM Change
avatar brianteeman brianteeman - open - 23 Sep 2023
avatar brianteeman brianteeman - change - 23 Sep 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 23 Sep 2023

removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.

avatar brianteeman brianteeman - change - 23 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar brianteeman
brianteeman - comment - 23 Sep 2023

removing the asset from the joomla.asset.json could lead to an exception if 3rd party uses it. since we don't have a policy for it. Please move this entry to the b/c plugin with an empty file reference and update the manual b/c / deprecation section.

sorry - not sure exactly what you are asking for here

avatar HLeithner
HLeithner - comment - 23 Sep 2023

more or like a copy of that what the compat plugin does for the es5 assets. new json file with the removed parts from this pr and loading the new json file when the es5 assets are loaded

avatar brianteeman
brianteeman - comment - 23 Sep 2023

sorry I think I understand what you mean but I dont know what to put in place of the xxxxxxxxxxx


        /**
         * Load the es5 assets stubs, they are needed if an extension
         * directly uses a core es5 asset which has no function in Joomla 5+
         * and only provides an empty asset to not throw an exception
         */
        if ($this->params->get('es5_assets', '1')) {
            $event->getDocument()
                ->getWebAssetManager()
                ->getRegistry()
                ->addRegistryFile('media/plg_behaviour_compat/es5.asset.json');
        }

        /**
         * Load the com_scheduler.admin-view-select-task-css stub asset, if an extension
         * directly used it - very unlikely - to an asset which has no function in Joomla 5+
         * and only provides an empty asset to not throw an exception
         */
        if ($this->params->get('***************', '1')) {
            $event->getDocument()
                ->getWebAssetManager()
                ->getRegistry()
                ->addRegistryFile('media/plg_behaviour_compat/**********.json');
        }
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_admin Repository NPM Change Administration com_admin com_banners com_content com_fields com_installer com_joomlaupdate com_menus com_modules com_templates com_users Language & Strings Modules
avatar brianteeman brianteeman - change - 26 Sep 2023
Labels Added: Feature
avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_admin com_banners com_content com_fields com_installer com_joomlaupdate com_menus com_modules com_templates com_users Language & Strings Modules Administration com_admin Repository NPM Change
avatar brianteeman brianteeman - change - 26 Sep 2023
Labels Added: Language Change
Removed: NPM Resource Changed
avatar richard67
richard67 - comment - 26 Sep 2023

@brianteeman Shall I help with the merge conflicts?

avatar brianteeman brianteeman - change - 26 Sep 2023
Labels Added: NPM Resource Changed
Removed: Language Change
avatar brianteeman
brianteeman - comment - 26 Sep 2023

@richard67 yes please - not in the right headspace today to resolve it

avatar brianteeman
brianteeman - comment - 26 Sep 2023

Any help with this would be appreciated as well #41871 (comment)

@wilsonge @HLeithner @richard67

avatar wilsonge
wilsonge - comment - 26 Sep 2023

I think like this

if ($this->params->get('es5_assets', '1')) {

avatar richard67
richard67 - comment - 26 Sep 2023

@brianteeman Conflicts resolved. With the other thing I don't know yet if I can help.

avatar richard67
richard67 - comment - 26 Sep 2023

System tests will fail in Drone due to unrelated reasons, see #41938 .

avatar brianteeman
brianteeman - comment - 26 Sep 2023

thanks @richard67

@wilsonge yes I assumed that in my post just dont have a clue what to put in place of the xxxxxxxxxx in my code snippet

avatar wilsonge
wilsonge - comment - 26 Sep 2023

Create a new parameter in the plugin. Doesn't make sense to mix this with the existing es5 assets

avatar brianteeman
brianteeman - comment - 26 Sep 2023

thats what i am doing arent i? just need to know what to put instead of the xxxxxxxxxxx

/me confused

avatar wilsonge
wilsonge - comment - 26 Sep 2023

https://github.com/joomla/joomla-cms/blob/5.0-dev/plugins/behaviour/compat/compat.xml#L36-L47 new param in here to match and then pick a name. removed_assets seems reasonable and we can polyfill any others into the same param rather than doing a param per asset.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_admin Repository NPM Change Administration com_admin Language & Strings Repository NPM Change Front End Plugins
avatar brianteeman brianteeman - change - 26 Sep 2023
Labels Added: Language Change
avatar brianteeman
brianteeman - comment - 26 Sep 2023

Hopefully I just got it right now. As soon as you mentioned the xml it started to click

avatar wilsonge
wilsonge - comment - 26 Sep 2023

Looks fine to me

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_admin Repository NPM Change Language & Strings Front End Plugins Administration com_admin Language & Strings Repository NPM Change JavaScript Front End Plugins
7f9d398 26 Sep 2023 avatar brianteeman js
avatar HLeithner HLeithner - change - 30 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-30 20:26:13
Closed_By HLeithner
avatar HLeithner HLeithner - close - 30 Sep 2023
avatar HLeithner HLeithner - merge - 30 Sep 2023
avatar brianteeman
brianteeman - comment - 30 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment