[#41864] - [5.0] Dark mode support for guided tours
- Fixed in Code Base
- 24 Sep 2023
- Medium
- Build: 5.0-dev
- # 41864
- Diff
- wilsonge:fix/dark-mode-guided-tours
User tests: Successful: Unsuccessful:
Pull Request for Issue #41861 .
Summary of Changes
Adds CSS overrides for the modals that are used in guided tours so they render in dark mode. I'm honestly not convinced the color contrast for the header (using the --dark-bg-subtle color) gives enough contrast to the main body background. We may need to go with something a touch lighter. But should be an easy fix if someone can suggest something.
@HLeithner this one is more complicated so recommend we get two good tests here
Testing Instructions
Please test a few different tours so you get different sized modals and text.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
I have tested this item ✅ successfully on 0eb52fc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41864.
Looks cool in dark mode...
I have tested this item ✅ successfully on 0eb52fc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41864.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41864.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-24 06:29:38 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thx
@obuisard can you test this please?