Feature Composer Dependency Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
22 Sep 2023

Summary of Changes

Updating weak dependencies and Webauthn-lib from 4.3.0 to 4.5.2

Testing Instructions

Test all Variant of Webauthn/Passkeys

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Additional

Webauthn plugin needs to be updated because of many new deprecation in the upstream library

avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2023
Category External Library Composer Change
avatar HLeithner HLeithner - open - 22 Sep 2023
avatar HLeithner HLeithner - change - 22 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 22 Sep 2023
Labels Added: Composer Dependency Changed PR-5.0-dev
avatar HLeithner
HLeithner - comment - 23 Sep 2023

PR seems to break webauthn/passkeys

avatar Fedik
Fedik - comment - 25 Sep 2023

Try to change version to 4.5, as on their documentation it is latest https://webauthn-doc.spomky-labs.com/the-project/the-project
4.7 probably some transition stuff on the way to 5.0, there no docs about it.

avatar HLeithner HLeithner - change - 25 Sep 2023
Labels Added: Feature
avatar HLeithner
HLeithner - comment - 25 Sep 2023

ok, downgraded to 4.5.2

avatar richard67 richard67 - change - 26 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 26 Sep 2023
avatar richard67 richard67 - test_item - 26 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 26 Sep 2023

I have tested this item ✅ successfully on 26a418c

Unfortunately I have only one Webauthn method available, the Windows Hello PIN.

I've successfully tested that this method works for both the primary login and the MFA on a new installation made with the branch of this PR, and I have also tested that primary login and MFA with this method set up on a 4.4-dev still work after updating to the patched package for this PR.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862.
avatar HLeithner HLeithner - test_item - 26 Sep 2023 - Tested successfully
avatar HLeithner
HLeithner - comment - 26 Sep 2023

I have tested this item ✅ successfully on 26a418c

tested both 2FA and Passkeys with hardware key on linux with vivaldi.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41862.

avatar HLeithner HLeithner - close - 26 Sep 2023
avatar HLeithner HLeithner - merge - 26 Sep 2023
avatar HLeithner HLeithner - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 11:23:59
Closed_By HLeithner

Add a Comment

Login with GitHub to post a comment