Feeling Lucky
NPM Resource Changed
bug
PR-5.0-dev
?
[#41859] - [5.0] Fix missing dependency for editors asset
- Fixed in Code Base
- 22 Sep 2023
- Medium
- Build: 5.0-dev
- # 41859
- Diff
- Fedik:fix-editors-deps
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
The editors asset is depend from JoomlaDialog, hovewer the dependency is not defined.
Testing Instructions
Run npm install
In dashboard select Add module => Custom HTML module.
Inspect browser dev console
Actual result BEFORE applying this Pull Request
An error Failed to resolve module specifier "joomla.dialog"
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
HLeithner
- comment
- 22 Sep 2023
Strange I don't have this error with beta2
| Labels |
Added:
NPM Resource Changed
bug
PR-5.0-dev
?
|
||
HLeithner
- comment
- 22 Sep 2023
ok found the error, thanks
HLeithner
- comment
- 22 Sep 2023
I have tested this item ✅ successfully on 4b519b8
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41859.
HLeithner
- comment
- 22 Sep 2023
thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-22 17:06:07 |
| Closed_By | ⇒ | HLeithner |
I have tested this item ✅ successfully on 1209779
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41859.