Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41857] - [5.0] Restore possibility to use class for mod chrome

? bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
22 Sep 2023

Pull Request for Issue # .

Summary of Changes

In past it was possible to use:

<jdoc:include type="modules" name="main-top" style="card"  class="foobar"/>

Addittionaly I have added a default class to quickicon modules, to address :has issue in #41659

Testing Instructions

Apply patch,
Inspect home dashboard quickicon modules, page source, now they have an extra class in wrapper.

Or edit index.php of site template, change

<jdoc:include type="modules" name="main-top" style="card"/>

To:

<jdoc:include type="modules" name="main-top" style="card"  class="foobar"/>

Then open home page and Inspect this modules in page source, now they have an extra class in wrapper.

Actual result BEFORE applying this Pull Request

No extra class

Expected result AFTER applying this Pull Request

Extra class is there

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 22 Sep 2023
Category ⇒ Administration com_cpanel Templates (admin) Layout Front End Templates (site)
avatar Fedik Fedik - open - 22 Sep 2023
avatar Fedik Fedik - change - 22 Sep 2023
Status New ⇒ Pending
avatar Fedik Fedik - change - 22 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 22 Sep 2023
avatar Fedik Fedik - change - 22 Sep 2023
Labels Added: bug PR-5.0-dev
avatar obuisard obuisard - test_item - 22 Sep 2023 - Tested successfully
avatar obuisard
obuisard - comment - 22 Sep 2023

I have tested this item ✅ successfully on 7ef8627

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41857.

avatar Quy Quy - test_item - 22 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 22 Sep 2023

I have tested this item ✅ successfully on 7ef8627

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41857.

avatar Quy Quy - change - 22 Sep 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 22 Sep 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41857.

avatar HLeithner HLeithner - change - 22 Sep 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-22 16:24:10
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 22 Sep 2023
avatar HLeithner HLeithner - merge - 22 Sep 2023
avatar HLeithner
HLeithner - comment - 22 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment