Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41844] - Reduce the version hash length

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
20 Sep 2023

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2023
Category ⇒ JavaScript Repository
avatar dgrammatiko dgrammatiko - open - 20 Sep 2023
avatar dgrammatiko dgrammatiko - change - 20 Sep 2023
Status New ⇒ Pending
avatar dgrammatiko dgrammatiko - change - 20 Sep 2023
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 20 Sep 2023

why? where is it used?

avatar dgrammatiko
dgrammatiko - comment - 20 Sep 2023

why? where is it used?

The production zips have versioned css/js (in their joomla.assets.json) so the browser caching would be the most effective it could:

joomla-cms/build/build.php

Line 306 in 1739c46

system('npm run versioning', $verReturnCode);

avatar HLeithner
HLeithner - comment - 21 Sep 2023

should also be reduced to 6 chars

avatar dgrammatiko
dgrammatiko - comment - 21 Sep 2023

should also be reduced to 6 chars

Already done here:

joomla-cms/build/build-modules-js/versioning.es6.js

Line 64 in 721c32c

asset.version = hash.substring(0, 6);

this pr just changes the algo from sha1 to md5. Also im not in favour of capping the hash but that’s another conversation

avatar HLeithner HLeithner - change - 21 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-21 13:10:00
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 21 Sep 2023
avatar HLeithner HLeithner - merge - 21 Sep 2023
avatar HLeithner
HLeithner - comment - 21 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment