NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
19 Sep 2023

Pull Request for Issue #41813 .

Summary of Changes

Changes the info color for dark mode and removes an unused border parameter.

Testing Instructions

In the database maintaince view check the color is now legible and a11y compliant

Actual result BEFORE applying this Pull Request

maintenance-database

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 19 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 19 Sep 2023
avatar wilsonge wilsonge - change - 19 Sep 2023
Status New Pending
avatar Quy
Quy - comment - 19 Sep 2023

Please see the close (X) icon where it has a white outline.

avatar wilsonge wilsonge - change - 19 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar wilsonge
wilsonge - comment - 19 Sep 2023

Fixed

avatar richard67
richard67 - comment - 19 Sep 2023

@wilsonge Could you fix the scss-cs error reported in drone?

build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-alert.scss
10s
8 133:5 ✖ Expected "text-shadow" to come before "opacity" order/properties-order

2562199 19 Sep 2023 avatar wilsonge CS
avatar wilsonge
wilsonge - comment - 19 Sep 2023

Done

avatar Quy Quy - test_item - 19 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 19 Sep 2023

I have tested this item ✅ successfully on 2562199


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41815.

avatar HLeithner HLeithner - close - 20 Sep 2023
avatar HLeithner HLeithner - merge - 20 Sep 2023
avatar HLeithner HLeithner - change - 20 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-20 08:21:22
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 20 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment