[#41814] - [5.0] Move integration points for media manager into the variables file
- Fixed in Code Base
- 20 Sep 2023
- Medium
- Build: 5.0-dev
- # 41814
- Diff
- wilsonge:refactor/media-manager-scss-variables
User tests: Successful: Unsuccessful:
Summary of Changes
Moves all use of CSS variables in media manager to the _variables.scss file. This makes it easier to find for templates what CSS variables are required for integration (i.e. everything that is var(--template-* now lives in _variables.scss). For maintainers I've tried to comment all the things that are more than just moving variables around.
Testing Instructions
Check media manager renders the same as before. The only color changes is on active actions menu items when selecting an item and it should effectively be not noticeable.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-20 08:33:32 |
| Closed_By | ⇒ | HLeithner |
thanks, I think it's better to have variables there then hardcoded colors.