not sure why it should not be triggered, it's still in the ModuleHelper

@HLeithner The code you are referencing is in a method that is not (always?) called when template positions are rendered.
The whole ModulesRenderer.php looks to be a bit of a mess, to be honest. Duplicate code, different code styles (ways of triggering events, for instance), not clear what methods have what functionality and when they are used...

@HLeithner Also, that load method does everything on an empty modules array. Which makes no sense to me.

The event works as expected:

public function onPrepareModuleList(\Joomla\CMS\Event\Module\PrepareModuleListEvent $event)
{
  $modules = $event->getModules();
  dump(count($modules));
}

public function onPrepareModuleList(ArrayProxy &$modules)

It is wrong use of the event.

There is no onPrepareModuleList event being triggered in the new module position rendering.

No. It is trigering only once before all modules for the page are loaded.

Nthing to fix. I closing it. Thanks for your time.

Why close this... try it out with the plugin... you'll see that you can't change the modules list(s) that are rendered on the page.

Please back up your claim that everything works as it should with some proof.

Perhaps we have here a backwards compatibility issue as @regularlabs mentioned that it was working in J4.

Then please provide a better description for your issue. What exactly does not work.

The specific event onPrepareModuleList works as expected.

public function onPrepareModuleList(\Joomla\CMS\Event\Module\PrepareModuleListEvent $event)
{
  $modules = $event->getModules();
  dump(count($modules));
}

When I do that on a clean Joomla 5 installation, it outputs 0. And only once.
The onPrepareModuleList should be called for every module position on the page.

To ask this in a different way:
Can you give me the plugin code to remove the first module in a module position?

(And yes, the answer for all previous Joomla versions is to use onPrepareModuleList)
(And no, this does not work on Joomla 5)

When I do that on a clean Joomla 5 installation, it outputs 0. And only once.
The onPrepareModuleList should be called for every module position on the page.

Why do you think that?
It was made to be only once, since this event exists. You can check the origin here #6320

There 2 more events used to clean the modules list: onAfterModuleList and onAfterCleanModuleList you can use them to remove unneded modules.

I'll look into this.

From the history, purpuse of onPrepareModuleList not the same as example onContentPrepare or onContentPrepareForm, it may confuse, but it is what it is.

Confirmed. The $modules = $event->getModules(); returns an empty array. We have a problem.

We have a problem.

Would be nice if you read the comments. Thanks in advance.

No, @Fedik was right. Error was on my side (assumptions I was making).

But there is a wrong code in the ModuleHelper.
How to set the $modules array now?

Indeed the onPrepareModuleList produces no effects. The ArrayProxy object wraps the $modules array, so it will be always empty when checking with: if (!$modules) {

    ```
    $dispatcher = Factory::getApplication()->getDispatcher();
    $modules    = [];

    $dispatcher->dispatch('onPrepareModuleList', new Module\PrepareModuleListEvent('onPrepareModuleList', [
        'subject' => new ArrayProxy($modules),
    ]));

    // If the onPrepareModuleList event returns an array of modules, then ignore the default module list creation
    if (!$modules) {
        $modules = static::getModuleList();
    }

How to set the $modules array now?

This event was made for very specific cases. Not really for average use.
Look the comment in the code that you posted.
Also original PR #6320

How to set the $modules array now?

This event was made for very specific cases. Not really for average use. Look the comment in the code that you posted. Also original PR #6320

@Fedik i still don't understand. In J4 i was just loading the $modules list and it worked. Now it is no longer possible.
Can you please let me know how this event should be used then?

Look the comment in the code that you posted.

There is no assignment if the onPrepareModuleList event returns an array of modules

So it can't work

It is working. A magic ?

The only way to have it working would be to set the modules list in the $data variable of ArrayProxy, but it is protected.

Other than this, nothing works. Please check better.

Did you tried?
Please show me the code you tried.
Hint: ArrayProxy implements ArrayAccess

Of course!!! I'm debugging it now with XDebug.

How can it work if there is no reference to the $modules array?

The ModuleHelper checks the $modules array that always stays empty after the call to onPrepareModuleList:

       if (!$modules) {
            $modules = static::getModuleList();
        }

There is no way to manipulate it as long as it stays within the ArrayProxy object. The & reference is not possible, the $event->setArgument('subject', $subject); is also not effective.

The only thing that works for the reference, is to set again the data property of the ArrayAccess object:

$subject->data = $modules;
$event->setArgument('subject', $subject);

$subject->data = $modules;
$event->setArgument('subject', $subject);

What is it man? how do you use it in joomla 4 and 3?

$modules = $event->getModules();
$modules[] = ... add module1;
$modules[] = ... add module2;
...so on
unset($modules[0]); // remove first module

@regularlabs a note, I noticed your code:
onPrepareModuleList(ArrayProxy &$modules)
$modules->offsetUnset(0);

If you have this or similar code in your extension please update it to use a regular array (or use an event instance)
We are removing ArrayAccess wrapper for $modules array in upcoming beta.
Thanks!

Ok, great.