? bug PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
11 Sep 2023

Summary of Changes

there are differentes between:

  • php installation/joomla.php install (in root folder)
  • php joomla.php install (in install folder)

use same folder constant for InstallCommand/InstallationController like in DatabaseModel:

$schemaFile = JPATH_INSTALLATION . '/sql/' . $serverType . '/' . $schema . '.sql';

Testing Instructions

try to install eg. german localised language pack

Actual result BEFORE applying this Pull Request

only variant 2 is working

Expected result AFTER applying this Pull Request

both variants are working

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 11 Sep 2023
Category Installation
avatar heelc29 heelc29 - open - 11 Sep 2023
avatar heelc29 heelc29 - change - 11 Sep 2023
Status New Pending
avatar richard67
richard67 - comment - 12 Sep 2023
avatar richard67 richard67 - test_item - 12 Sep 2023 - Tested successfully
avatar richard67
richard67 - comment - 12 Sep 2023

I have tested this item ✅ successfully on 4bae520

Without the PR, no German language was installed and no localisations have been made at variant 1. With the PR, it worked, and variant 2 worked as well as before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41706.

avatar alikon alikon - test_item - 12 Sep 2023 - Tested successfully
avatar alikon
alikon - comment - 12 Sep 2023

I have tested this item ✅ successfully on 4bae520

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41706.

avatar alikon alikon - change - 12 Sep 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 12 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41706.

avatar obuisard obuisard - change - 12 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 20:29:07
Closed_By obuisard
Labels Added: ? bug PR-4.3-dev
avatar obuisard obuisard - close - 12 Sep 2023
avatar obuisard obuisard - merge - 12 Sep 2023
avatar obuisard
obuisard - comment - 12 Sep 2023

Thanks @heelc29 for the PR!

Add a Comment

Login with GitHub to post a comment