Feeling Lucky
?
PR-4.4-dev
[#41695] - system test com_templates webservices
- Fixed in Code Base
- 11 Sep 2023
- Medium
- Build: 4.4-dev
- # 41695
- Diff
- alikon:template-endpoint-cypress
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
API tests for following endpoints:
- GET: /api/index.php/v1/templates/styles/site
- GET: /api/index.php/v1/templates/styles/site/{id}
- PATCH: /api/index.php/v1/templates/styles/site/{id}
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-4.4-dev
|
||
laoneo
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-11 13:50:08 |
| Closed_By | ⇒ | laoneo |
alikon
- comment
- 12 Sep 2023
the problem is that even if you don't include template in the payload of the PATCH request
as per https://github.com/joomla/joomla-cms/blob/4.4-dev/libraries/src/MVC/Controller/ApiController.php#L397-L406
it's included as well, there are some keys like template and or password that for PATCH needs some extra management
done in the preprocessSaveData
That silent error seems wrong to me, we shouldn't ignore modification requests without noticed, actually the exception is right from my point of view. the
patchrequest shouldn't include a thetemplatein the first place