? bug ? PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
9 Sep 2023

Pull Request for Issue #41681 .

Summary of Changes

fix PATCH user alters password

Testing Instructions

#41681

Actual result BEFORE applying this Pull Request

after PATCH unable to login for that user

Expected result AFTER applying this Pull Request

able to login

avatar alikon alikon - open - 9 Sep 2023
avatar alikon alikon - change - 9 Sep 2023
Status New Pending
avatar hefferbub hefferbub - test_item - 10 Sep 2023 - Tested successfully
avatar hefferbub
hefferbub - comment - 10 Sep 2023

I have tested this item ✅ successfully on bf01492

Tested by replacing the one changed source file on a stock 4.3.4 installation and the fix worked as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41688.

avatar laoneo
laoneo - comment - 11 Sep 2023

Can you rebase this to 4.4 and add a system test?

avatar alikon alikon - change - 12 Sep 2023
Labels Added: bug ? PR-4.4-dev
avatar alikon
alikon - comment - 12 Sep 2023

rebased to 4.4
for the system test... ? in the week-end or so

avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2023
Category JavaScript Unit Tests
avatar alikon alikon - change - 13 Sep 2023
Labels Added: ?
avatar laoneo
laoneo - comment - 15 Sep 2023

I don't like the mix of api tests with front end tests. Can this not be tested somehow differently if the password works?

avatar alikon
alikon - comment - 15 Sep 2023

probably yes, but How ?

avatar MacJoom
MacJoom - comment - 18 Sep 2023

we would need to add an webservices rest api function to test the password

avatar wilsonge
wilsonge - comment - 26 Sep 2023

probably yes, but How ?

Just directly query the database. We don't really care about the raw password. Just the hash is unchanged before and after the webservice request.

avatar laoneo laoneo - change - 26 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-26 10:21:33
Closed_By laoneo
avatar laoneo laoneo - close - 26 Sep 2023
avatar laoneo laoneo - merge - 26 Sep 2023
avatar laoneo
laoneo - comment - 26 Sep 2023

Thanks!

Add a Comment

Login with GitHub to post a comment