[#41680] - [5.0] Modal Dialog for User field
- Fixed in Code Base
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41680
- Diff
- Fedik:popup-user
User tests: Successful: Unsuccessful:
Summary of Changes
Use Joomla dialog and postMessage for user field, instead of BS modal.
It may not hit 5.0, but in future will need to update anyway.
Testing Instructions
Apply patch, run npm install
Create User field, or use existing. try select the field value.
<field type="user" name="user_test" label="User"/>Actual result BEFORE applying this Pull Request
Works with BS modal
Expected result AFTER applying this Pull Request
Works with joomla dialog
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: as part of joomla/Manual#178 and joomla/Manual#99
- No documentation changes for manual.joomla.org needed
References:
joomla-cms-bot
- | Category | ⇒ | Administration com_users Repository NPM Change JavaScript Layout |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
NPM Resource Changed
PR-5.0-dev
|
||
| Title |
|
||||||
IMO J5 either uses BS modals or it uses dialogs,
It is not possible to change all at once, physically.
but what is the reason for switching from BS Modals to JS Dialogs
With BS you always should have pre-rendered HTML on the page.
With Dialog you can construct it on the way, load content with AJAX, much more flexible.
Something like it was in J 1.5-2.5 with SqueezeBox.
Is there any discussion on this
You can look linked issues in description of:
Also discussion:
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 14:29:58 |
| Closed_By | ⇒ | HLeithner |
thx
Hi Fedik,
IMO J5 either uses BS modals or it uses dialogs, having a mix makes things more complex. I have seen this with name spacing and service providers which where introduced in 4.0 but needed up until 4.3 to be completed (and not sure if it is already complete?)
And I probably missed it, but what is the reason for switching from BS Modals to JS Dialogs? Is there any discussion on this that I (we as developers) can read up on?
Thanks,
Regards, Ruud
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41680.