Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41673] - 5.0 Uncatched PublicFolderGeneratorHelper::createPublicFolder() exception, invalid void result used

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
8 Sep 2023

Summary of Changes

PublicFolderGeneratorHelper::createPublicFolder() is void, we need to catch exception but not check the return result.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

See the code.

Expected result AFTER applying this Pull Request

Good code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

48a188a 8 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2023
Category ⇒ Libraries
avatar Denitz Denitz - open - 8 Sep 2023
avatar Denitz Denitz - change - 8 Sep 2023
Status New ⇒ Pending
avatar Denitz Denitz - change - 8 Sep 2023
Title
…
5.0 Uncatch PublicFolderGeneratorHelper::createPublicFolder() exception, invalid void result used
5.0 Uncatched PublicFolderGeneratorHelper::createPublicFolder() exception, invalid void result used
avatar Denitz Denitz - edited - 8 Sep 2023
avatar HLeithner HLeithner - change - 19 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-19 08:01:23
Closed_By ⇒ HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 19 Sep 2023
avatar HLeithner HLeithner - merge - 19 Sep 2023
avatar HLeithner
HLeithner - comment - 19 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment