[#41672] - [5.0] Redundant `else` usage
- Fixed in Code Base
- 17 Sep 2023
- Medium
- Build: 5.0-dev
- # 41672
- Diff
- Denitz:5.0_Redundant_'else'_usage
User tests: Successful: Unsuccessful:
Summary of Changes
else after return creates additional complexity and doesn't have sense.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Strange code.
Expected result AFTER applying this Pull Request
Nice code.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
The tool found the problems, next I manually updated the code.
Which tool?
I would rather add the tool to our CI pipeline instead of manually improving our code base.
It's Php Inspections (EA Extended) for PhpStorm plugin, not a case for CI here.
Can yo add the no useless else rule to the cs definition file.
Sorry, I am not a huge expert in cs files, all other changes applied.
| Labels |
Added:
?
|
||
You don't need to be an expert, just add the rule to the file I posted.
| Category | Administration com_banners com_categories com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates com_users | ⇒ | Administration com_banners com_categories com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_menus com_messages com_modules com_newsfeeds com_plugins com_redirect com_tags com_templates |
Nice, now the checker found 3 more occurrences. Can you fix them as well?
You are almost there
| Title |
|
||||||
There is now a conflict. Beside that looks good to me. Didn't do a full review. But leave it up to @HLeithner if he wants to add it into 5.0.
I'm merging this before beta2 so it'S a good improvement for readability. One thing that could be improved is to use early return also here
joomla-cms/libraries/src/Proxy/ArrayReadOnlyProxy.php
Lines 38 to 46 in b8ecf77
thanks
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-17 20:39:34 |
| Closed_By | ⇒ | HLeithner |
Did you make this manually or with a tool?