Feeling Lucky
PR-5.0-dev
[#41668] - 5.0 mt_rand() to random_int()
- Closed
- 11 Sep 2023
- Medium
- Build: 5.0-dev
- # 41668
- Diff
- Denitz:5.0_mt_rand()_to_random_int()
User tests: Successful: Unsuccessful:
Summary of Changes
random_int() is preferred over mt_rand(), see https://www.php.net/manual/en/function.mt-rand
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Usual code.
Expected result AFTER applying this Pull Request
Better code.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Installation Modules Front End |
| Status | New | ⇒ | Pending |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-11 09:44:34 |
| Closed_By | ⇒ | Denitz | |
| Labels |
Added:
PR-5.0-dev
|
||
It Is preferred... in what case?
random_int is far slower than mt_rand()/rand(). It should only be used where cryptographically security is needed.
I don't think you need this kind of security during the generation of root ID during installation, or in the plugin function that chooses a random image.