User tests: Successful: Unsuccessful:
track_errors is deprecated as of PHP 7.2.0, removed as of PHP 8.0.0.
enabled track_errors results to possible error message in global $php_errormsg which is also deprecated in favour of error_get_last().
I didn't see any traces of using $php_errormsg with InstallerHelper::downloadPackage()
Language package could use $php_errormsg to get errors from .ini files.
Apply patch.
Bad code.
Goof code, rely on exceptions.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-5.0-dev
|
||
I've updated the Summary of Changes with more details.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 14:56:07 |
| Closed_By | ⇒ | HLeithner |
before simply deleting this code it should be estabalished what its intended purpose was and then ensure that deleting the code is a suitable option. Is that intended purpose no longer relevant?