PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
8 Sep 2023

Summary of Changes

track_errors is deprecated as of PHP 7.2.0, removed as of PHP 8.0.0.

enabled track_errors results to possible error message in global $php_errormsg which is also deprecated in favour of error_get_last().

I didn't see any traces of using $php_errormsg with InstallerHelper::downloadPackage()
Language package could use $php_errormsg to get errors from .ini files.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Bad code.

Expected result AFTER applying this Pull Request

Goof code, rely on exceptions.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

15fd118 8 Sep 2023 avatar fix
avatar joomla-cms-bot joomla-cms-bot - change - 8 Sep 2023
Category Libraries
avatar Denitz Denitz - open - 8 Sep 2023
avatar Denitz Denitz - change - 8 Sep 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 8 Sep 2023

before simply deleting this code it should be estabalished what its intended purpose was and then ensure that deleting the code is a suitable option. Is that intended purpose no longer relevant?

avatar Quy
Quy - comment - 8 Sep 2023

Please see #39057 for the suggested route to solve this.

avatar Denitz Denitz - change - 8 Sep 2023
Labels Added: PR-5.0-dev
avatar Denitz Denitz - change - 8 Sep 2023
The description was changed
avatar Denitz Denitz - edited - 8 Sep 2023
avatar Denitz
Denitz - comment - 8 Sep 2023

I've updated the Summary of Changes with more details.

avatar Denitz Denitz - change - 8 Sep 2023
The description was changed
avatar Denitz Denitz - edited - 8 Sep 2023
avatar HLeithner
HLeithner - comment - 12 Sep 2023

closing this in favor for #39057 @Hackwar can you please bring your pr uptodate and add the new error handling please (or close your pr)

avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-12 14:56:07
Closed_By HLeithner
avatar HLeithner HLeithner - close - 12 Sep 2023

Add a Comment

Login with GitHub to post a comment