User tests: Successful: Unsuccessful:
I know that instantiate has a very specific meaning to developers but its pretty meaningless to regular folk. This PR simplifies the language string so that they might actually understand the error message if they are ever unlucky enough to see it
PHPMAILER_INSTANTIATE
Could not instantiate mail function.
==> Could not start ..
JLIB_UTIL_ERROR_APP_INSTANTIATION
Application Instantiation Error
==>Application Startup ...
Status | Pending | ⇒ | New |
Labels |
Added:
?
|
Status | New | ⇒ | Ready to Commit |
Status | Ready to Commit | ⇒ | Needs Review |
Matt is right and people will be better able to understand "what went wrong" Nice touch Brian.
This needs no further testing me think so changed to RTC
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
@brianteeman
I have changed again the status to "Need review". When I run in com_Patchtester the patch for "Add support for PDO based connections for MySQL" (4123) I get an error
"Error
The patch could not be applied because it conflicts with a previously applied patch: administrator/language/en-GB/en-GB.ini"
I revert this patch and the PDO-patch does not throw the error. So it seems that somewhere we need to address this issue also in the #4123.
Can you coordinate sync with @mbabker re. this language change?
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
That's not an issue with this patch by itself.
Maybe you had the patch tested with the Patchtester and still applied? Then you just need to revert it with the Patchtester.
If it generates conflicts because both change the same files, then that is something which happens quite often and which Git usually can handle by itself.
Status | Needs Review | ⇒ | New |
Labels |
Added:
?
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-25 14:48:07 |
Thanks for making this adjustment. Just as you stated, it's technically correct however it's one of the top questions we get from end users.