Feature NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 Sep 2023

Summary of Changes

Changing Modal_Menu field to use new modal dialog.
The same as #40462 but for Menu.

It may not hit 5.0, but in future will need to update anyway.

TODO: Will be need to update after #41600

Testing Instructions

Run npm install

Create/edit "Menu Item Type": "Menu Item Alias": create/edit/select "Menu Item" value.

Actual result BEFORE applying this Pull Request

Works with old bs modal

Expected result AFTER applying this Pull Request

Works with new dialog.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: as part of joomla/Manual#178
  • No documentation changes for manual.joomla.org needed

Reference:

avatar joomla-cms-bot joomla-cms-bot - change - 7 Sep 2023
Category Administration com_menus JavaScript Repository NPM Change
avatar Fedik Fedik - open - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
Status New Pending
avatar Fedik Fedik - change - 7 Sep 2023
Labels Added: Feature NPM Resource Changed PR-5.0-dev
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar Fedik Fedik - change - 7 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 7 Sep 2023
avatar ceford ceford - test_item - 7 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 7 Sep 2023

I have tested this item ✅ successfully on cf30063


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41629.

avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023
avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 18:18:53
Closed_By HLeithner

Add a Comment

Login with GitHub to post a comment