NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
6 Sep 2023

Summary of Changes

Follow up to an issue raised by @Quy in the dark mode PR. Also improves the experience in light mode by using the template themed color in light mode as well rather than the bootstrap primary color (so in non-blue color schemes the tab color appears more in keeping with the site design)

Testing Instructions

When editing a template look at the tab presets before and after applying this PR (note this is a SCSS based PR so patchtester will not work)

Validate that the active tab, hover and focus effects on tabs work in both light and dark mode of the template. In light mode there will be a slight shift (which should be borderline unnoticeable unless you change the template theme from the default preset) and in dark mode currently you get a very dark blue color on hover which is now effectively removed by using the template light text color.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 6 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 6 Sep 2023
avatar wilsonge wilsonge - change - 6 Sep 2023
Status New Pending
avatar wilsonge wilsonge - change - 6 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 6 Sep 2023
avatar wilsonge wilsonge - change - 6 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 6 Sep 2023
avatar Quy Quy - test_item - 7 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 7 Sep 2023

I have tested this item ✅ successfully on 42cc647


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41625.

avatar HLeithner HLeithner - change - 12 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-12 18:18:31
Closed_By HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 12 Sep 2023
avatar HLeithner HLeithner - merge - 12 Sep 2023

Add a Comment

Login with GitHub to post a comment