[#41623] - [5.0] CLI install fix public folder language string
- Fixed in Code Base
- 12 Sep 2023
- Medium
- Build: 5.0-dev
- # 41623
- Diff
- heelc29:5.0/cli-install/public-folder-lang
User tests: Successful: Unsuccessful:
Summary of Changes
- remove description form
public_folder; language string not defined - fix language string for
public_folderin help command
Testing Instructions
execute php installation/joomla.php install -h
Actual result BEFORE applying this Pull Request
untranslated string
Expected result AFTER applying this Pull Request
translated
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
Votes
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings |
| Status | New | ⇒ | Pending |
I have tested this item ✅ successfully on 28bc032
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.
I think all of them should be DESC to be consistent with the other language strings in this file
You mean
INSTL_DATABASE_ENCRYPTION_CA_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_CERT_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_CIPHER_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_KEY_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_MODE_LABEL_SHORT
INSTL_DATABASE_ENCRYPTION_VERIFY_SERVER_CERT_LABEL_SHORT
yeah ok then I only saw them where I added the new strings and was already confused whats a DESC and a DESC_SHORT is but no LABEL exists...
so happy with anything we have
Uniform processing of the strings makes the most sense from a translation point of view, of course.
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
I have tested this item ✅ successfully on bdf2201
thanks @heelc29
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.
I have tested this item ✅ successfully on bdf2201
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41623.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-12 16:00:09 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks @heelc29 and @HLeithner
I think all of them should be DESC to be consistent with the other language strings in this file