Feature NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
5 Sep 2023

Pull Request for Issue # .

Summary of Changes

This update for TinyMCE to use asset registry,
And regular plugin, instead of external_plugin and HTMLHelper::_('script', 'plg_ ..... for Joomla custom plugins ,
Also this create jxtdbuttons plugin, to render XTD buttons, instead of hardocing it.

Testing Instructions

Apply patch, run npm install
Edit an article with TineMCE, also use XTD buttons

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works, but better

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2023
Category Repository NPM Change JavaScript Layout Front End Plugins
avatar Fedik Fedik - open - 5 Sep 2023
avatar Fedik Fedik - change - 5 Sep 2023
Status New Pending
avatar Fedik Fedik - change - 5 Sep 2023
The description was changed
avatar Fedik Fedik - edited - 5 Sep 2023
avatar Fedik Fedik - change - 5 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar brianteeman
brianteeman - comment - 5 Sep 2023

Before this PR If you disable all of the plugins of type editors-xtd then there is no CMS Content button
With this PR you still have the button even though it is empty

avatar Fedik
Fedik - comment - 5 Sep 2023

With this PR you still have the button even though it is empty

Yeap, should work now.

avatar brianteeman brianteeman - test_item - 5 Sep 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Sep 2023

I have tested this item ✅ successfully on 0635294


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41595.

avatar Fedik Fedik - change - 5 Sep 2023
Labels Added: Feature
avatar ceford ceford - test_item - 9 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 9 Sep 2023

I have tested this item ✅ successfully on d720009


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41595.

avatar HLeithner HLeithner - change - 17 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-17 17:35:54
Closed_By HLeithner
avatar HLeithner HLeithner - close - 17 Sep 2023
avatar HLeithner HLeithner - merge - 17 Sep 2023
avatar HLeithner
HLeithner - comment - 17 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment