PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
4 Sep 2023

Pull Request for pr #41469.

Summary of Changes

This fixes a regression of #41469. When a test mail is sent without an @ or | sign in the site name, then the preg replace call returns null.

Testing Instructions

  • Make sure you are on PHP 8.2
  • Set reporting to maximum in the joomla configuration
  • Set a site name without any special character
  • Send a test mail

Actual result BEFORE applying this Pull Request

A javascript error where the response shows some deprecated warnings that null should not be passed. The test mail doesn't contain the site name in the subject.

Expected result AFTER applying this Pull Request

Test mail is correctly sent with the sitename in the subject and no JS error.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category Administration com_config
avatar laoneo laoneo - open - 4 Sep 2023
avatar laoneo laoneo - change - 4 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 4 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-04 11:37:02
Closed_By HLeithner
Labels Added: PR-4.3-dev
avatar HLeithner HLeithner - close - 4 Sep 2023
avatar HLeithner HLeithner - merge - 4 Sep 2023

Add a Comment

Login with GitHub to post a comment