PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
4 Sep 2023

Pull Request for Issue # .

Summary of Changes

With pull requests #40788 , #40519 and #41326 , an insert statements for new scheduler tasks has been added to files "installation/sql/<dbtype>/extensions.sql".

When I helped to finalize these PRs I decided to do this insert statement without specifying the "created_by" user ID because I was not sure if that would be converted to the real super user ID at the end of the installation.

Now I have checked and know that this would already be the case. See this line here and the method where it's in: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/src/Model/ConfigurationModel.php#L281 .

This pull request (PR) here adds the "created_by" user ID = 42 to the insert statement like we already do it elsewhere, see e.g. here: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/sql/mysql/base.sql#L792-L793

We do that because it will not be replaced by the right user ID when the value is zero, see here: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/src/Model/ConfigurationModel.php#L291 .

Testing Instructions

Code review, or make a new installation and check that the 3 new tasks show the right created by user,

Actual result BEFORE applying this Pull Request

The created_by user ID is zero for the new tasks and will be set to the super user when editing the task.

Expected result AFTER applying this Pull Request

The created by user ID is 42 in the SQL statement, and after the installation the created_by user is the super user used for the installation.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category SQL Installation Postgresql
avatar richard67 richard67 - open - 4 Sep 2023
avatar richard67 richard67 - change - 4 Sep 2023
Status New Pending
avatar richard67 richard67 - change - 4 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 4 Sep 2023
avatar richard67 richard67 - change - 4 Sep 2023
Labels Added: PR-5.0-dev
avatar richard67 richard67 - change - 4 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 4 Sep 2023
avatar richard67 richard67 - change - 4 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 4 Sep 2023
avatar richard67 richard67 - change - 4 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 4 Sep 2023
avatar HLeithner HLeithner - change - 4 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-04 12:04:05
Closed_By HLeithner
avatar HLeithner HLeithner - close - 4 Sep 2023
avatar HLeithner HLeithner - merge - 4 Sep 2023

Add a Comment

Login with GitHub to post a comment