User tests: Successful: Unsuccessful:
Pull Request for Issue # .
With pull requests #40788 , #40519 and #41326 , an insert statements for new scheduler tasks has been added to files "installation/sql/<dbtype>
/extensions.sql".
When I helped to finalize these PRs I decided to do this insert statement without specifying the "created_by" user ID because I was not sure if that would be converted to the real super user ID at the end of the installation.
Now I have checked and know that this would already be the case. See this line here and the method where it's in: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/src/Model/ConfigurationModel.php#L281 .
This pull request (PR) here adds the "created_by" user ID = 42 to the insert statement like we already do it elsewhere, see e.g. here: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/sql/mysql/base.sql#L792-L793
We do that because it will not be replaced by the right user ID when the value is zero, see here: https://github.com/joomla/joomla-cms/blob/5.0-dev/installation/src/Model/ConfigurationModel.php#L291 .
Code review, or make a new installation and check that the 3 new tasks show the right created by user,
The created_by user ID is zero for the new tasks and will be set to the super user when editing the task.
The created by user ID is 42 in the SQL statement, and after the installation the created_by user is the super user used for the installation.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Category | ⇒ | SQL Installation Postgresql |
Status | New | ⇒ | Pending |
Labels |
Added:
PR-5.0-dev
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-04 12:04:05 |
Closed_By | ⇒ | HLeithner |