Feature NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
4 Sep 2023

Summary of Changes

For now only a new color is added for the Joomla 5 administrator interface
Some fixes are needed for buttons and other stuff, waiting for @TLWebdesign who started to find and fix some issues.

Testing Instructions

Install or Update Joomla
Look at the backend

Actual result BEFORE applying this Pull Request

Blue

Expected result AFTER applying this Pull Request

Teal

Preview

image

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category SQL Administration com_admin Postgresql Installation
avatar HLeithner HLeithner - open - 4 Sep 2023
avatar HLeithner HLeithner - change - 4 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 4 Sep 2023
The description was changed
avatar HLeithner HLeithner - edited - 4 Sep 2023
avatar brianteeman
brianteeman - comment - 4 Sep 2023

The templatedetails.xml needs to be updated with the new values - otherwise if you make a change you can never go back to this new default

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category SQL Administration com_admin Postgresql Installation SQL Administration com_admin Postgresql Templates (admin) Installation
avatar HLeithner HLeithner - change - 4 Sep 2023
Labels Added: PR-5.0-dev
avatar HLeithner
HLeithner - comment - 4 Sep 2023

The templatedetails.xml needs to be updated with the new values - otherwise if you make a change you can never go back to this new default

thanks updated

avatar brianteeman
brianteeman - comment - 4 Sep 2023

This color scheme does not have enough contrast to satisfy accessibility checks

As an example the areas highlighted below all fail as they have a contrast of only 3.81:1

image

avatar HLeithner
HLeithner - comment - 4 Sep 2023

This color scheme does not have enough contrast to satisfy accessibility checks

As an example the areas highlighted below all fail as they have a contrast of only 3.81:1

image

Tom updated also some css files, in this case I think he only changed the background-color to var(--template-bg-dark-65) instead of 60, but not sure. waiting for him.

avatar TLWebdesign
TLWebdesign - comment - 4 Sep 2023

Yes there needs to be some scss updated.

This is what i added to my user.css. Of course this needs to be changed in the appropriate scss files.

:root {
--template-bg-dark-60: hsl(var(--hue),40%,35%);
--card-color: var(--template-bg-dark-60);
--template-link-color: var(--template-bg-dark-75);
--template-contrast: var(--template-bg-dark-75);
--link-color: var(--template-bg-dark-75);
--template-link-hover-color: var(--template-bg-dark-90);
--link-hover-color: var(--template-bg-dark-90);
--icon-color: var(--template-bg-dark-60);
}
.pagination {
--pagination-active-bg: var(--template-bg-dark-70);
--pagination-active-border-color: var(--template-bg-dark-90);
}

.quick-icons .quickicon {
--text-color: var(--template-bg-dark-60);
}

.table thead a {
color: var(--template-bg-dark-75);
}

body .active>.page-link, .page-link.active {
background-color: var(--pagination-active-bg);
border-color: var(--pagination-active-border-color);
}

.form-check-input:checked {
background-color: var(--template-bg-dark-60);
border-color: var(--template-bg-dark-70);
}

.com_cpanel .cpanel-add-module {
color: var(--template-bg-dark-60);
}

avatar Fedik
Fedik - comment - 4 Sep 2023

Thses colors comes from parameters:

->addInlineStyle(':root {
--hue: ' . $matches[1] . ';
--template-bg-light: ' . $this->params->get('bg-light', '#f0f4fb') . ';
--template-text-dark: ' . $this->params->get('text-dark', '#495057') . ';
--template-text-light: ' . $this->params->get('text-light', '#ffffff') . ';
--link-color: ' . $linkColor . ';
--link-color-rgb: ' . $r . ',' . $g . ',' . $b . ';
--template-special-color: ' . $this->params->get('special-color', '#001B4C') . ';
}');

Would be good to get a new color codes, then we can replace them.

avatar brianteeman
brianteeman - comment - 4 Sep 2023

Yes there needs to be some scss updated.

As soon as you do that you need to make it a new template and not a new template style

avatar brianteeman
brianteeman - comment - 4 Sep 2023

Just change hsl(178, 63%, 20%) to hsl(192, 63%, 20%) and contrast issues fixed

image

avatar richard67
richard67 - comment - 4 Sep 2023

The green of the alerts together with the new greenish colours looks a bit ... weird ... as if from 2 different designers. But that might be my taste only.

avatar Fedik
Fedik - comment - 4 Sep 2023

192 looks good

avatar obuisard obuisard - test_item - 4 Sep 2023 - Tested successfully
avatar obuisard
obuisard - comment - 4 Sep 2023

I have tested this item ✅ successfully on f0d99dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41579.

avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2023
Category SQL Administration com_admin Postgresql Installation Templates (admin) SQL Administration com_admin Postgresql Templates (admin) Repository NPM Change Installation
avatar brianteeman
brianteeman - comment - 4 Sep 2023

other than forcing the documentation contributors to make brand new screenshots for everything what is the point of this change?

avatar obuisard
obuisard - comment - 4 Sep 2023

It's one of the possible ways to distinguish a Joomla 4 site from a Joomla 5 site.
Screenshots don't need to be re-created, especially that on update, the old style is preserved and can still be reverted to.

avatar HLeithner
HLeithner - comment - 5 Sep 2023

A new major version should get a "new" feeling, the color is the simplest way to do it, additionally I picked up the sidebar background which has been remove from 4.0 and thanks to @angieradtke it's updated a bit to reflect j5.
Nothing is final yet.

avatar brianteeman
brianteeman - comment - 5 Sep 2023

Fair enough. The same theory could be applied to the front end as well.

Perhaps using a child template as an example. (can we have child templates for the admin?)

avatar HLeithner
HLeithner - comment - 5 Sep 2023

Fair enough. The same theory could be applied to the front end as well.

true, but sadly nobody cared about it (which I understand since the last template team was attacked hardly, so I would also not touch this very opinionated topic)

Perhaps using a child template as an example. (can we have child templates for the admin?)

afaik yes, but I think that's not a good idea to do this in core because you can't extend a child template so if you want to do your own overrides for the backend you couldn't extend this core provided child template as parent.

avatar khu5h1 khu5h1 - test_item - 5 Sep 2023 - Tested successfully
avatar khu5h1
khu5h1 - comment - 5 Sep 2023

I have tested this item ✅ successfully on 4590f88


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41579.

avatar richard67
richard67 - comment - 5 Sep 2023

@HLeithner Drone is failing at the scss-cs step: https://ci.joomla.org/joomla/joomla-cms/69666/1/16

build/media_source/templates/administrator/atum/scss/blocks/_sidebar.scss
 9:3   ✖  Expected "background-image" to come before "box-shadow"  order/properties-order
 9:25  ✖  Expected quotes around "url" function argument           function-url-quotes
avatar ceford
ceford - comment - 5 Sep 2023

I applied the patch and ran npm ci - the only change I noticed is an 'x5x' background to the Admin menu. Have I missed something? How does this colour change relate to the Atum Style colour settings widget?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41579.

avatar richard67
richard67 - comment - 5 Sep 2023

I applied the patch and ran npm ci - the only change I noticed is an 'x5x' background to the Admin menu. Have I missed something? How does this colour change relate to the Atum Style colour settings widget?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41579.

@ceford It needs to apply the database changes when doing that on a running site. Or you make a new installation after having the patch applied and the npm ci, The database changes are here: https://github.com/joomla/joomla-cms/pull/41579/files#diff-026941c76fec80dda635e1c0eec0b2fbffb2053c6b6069f4a2ca20f21f8cab4c . Just replace the #__ by your actual db prefix.

5084187 5 Sep 2023 avatar HLeithner cs
avatar HLeithner HLeithner - change - 5 Sep 2023
Labels Added: NPM Resource Changed
avatar ceford
ceford - comment - 5 Sep 2023

I applied the patch and updated the database so it all works. But I don't like the colour scheme - looks like the old J4 blue has been covered by a thin mist of green. Like everybody else's bedroom: ghastly. There are 218 Help page screenshots to update.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41579.

avatar joeforjoomla
joeforjoomla - comment - 5 Sep 2023

A new major version should get a "new" feeling, the color is the simplest way to do it, additionally I picked up the sidebar background which has been remove from 4.0 and thanks to @angieradtke it's updated a bit to reflect j5. Nothing is final yet.

Nobody says that a major version should get a 'new' feeling, especially now that we want a smooth upgrade between major releases every 2 years. Look at Wordpress, the backend interface has never changed over years and across major releases. Your idea is quite questionable

avatar obuisard
obuisard - comment - 5 Sep 2023

Obviously, the color will not please everybody. When 4.0 came out, many hated the blue color, I can still hear the screams.
The decision for this PR does not fall on Harald @HLeithner alone, this has been discussed in team meetings, and been requested by many users (not the color itself, but the way to differentiate the major versions).

avatar brianteeman
brianteeman - comment - 5 Sep 2023

if only just one of those meetings had published minutes/report ...

avatar joeforjoomla
joeforjoomla - comment - 5 Sep 2023

Obviously, the color will not please everybody. When 4.0 came out, many hated the blue color, I can still hear the screams. The decision for this PR does not fall on Harald @HLeithner alone, this has been discussed in team meetings, and been requested by many users (not the color itself, but the way to differentiate the major versions).

But why nobody asks to differentiate Wordpress 5 from Wordpress 6? If there is a smooth upgrade process between major release, as it should be since now on for Joomla, also differentiating the backend interface using a color seems a pretty pointless thing. I would expect to find the usual interface in the backend after updating to 5, 6, etc

avatar TLWebdesign
TLWebdesign - comment - 5 Sep 2023

if only just one of those meetings had published minutes/report ...

https://volunteers.joomla.org/teams/marketing/reports/1914-marketing-minutes-august-29th-2023

avatar brianteeman
brianteeman - comment - 5 Sep 2023

if only just one of those meetings had published minutes/report ...

https://volunteers.joomla.org/teams/marketing/reports/1914-marketing-minutes-august-29th-2023

so marketing is driving code development now? I'm sure thats not what Olivier was referring to.

avatar TLWebdesign
TLWebdesign - comment - 5 Sep 2023

so marketing is driving code development now? I'm sure thats not what Olivier was referring to.

I was just answering your question. But no we're not. We're just helping when we're asked to do so. And we're excited to help with this because it helps to make sure that our marketing communications align with the design of joomla and that way we create extra recognition which is very important.

avatar richard67
richard67 - comment - 5 Sep 2023

Anyway the success and info colors used e.g. for alerts or toolbar buttons or quickicons do not look good together with the new template colors.

A bit like a pink tie on an orange shirt.

In J4 all colors of Atum and alerts and buttons and quickicons match together.

avatar TLWebdesign
TLWebdesign - comment - 5 Sep 2023

Anyway the success and info colors used e.g. for alerts or toolbar buttons or quickicons do not look good together with the new template colors.

A bit like a pink tie on an orange shirt.

Agreed. I tried about 10 different hues and my pick was a more saturated blue that i thought was vibrant and punchy. But in the end i'm not the one picking the colors. Marketing only had an advisory role here.

avatar coolcat-creations
coolcat-creations - comment - 8 Sep 2023

The color scheme does not really fit in my opinion, it makes Joomla look quite outdated.
just changing the hue does not work here. Also in my opinion Joomla had always some kind of blue as a main color?

avatar coolcat-creations
coolcat-creations - comment - 8 Sep 2023

If it needs to be immediately done i propose following values:
Hue 228
light background #f0f0f0
dark text #363636
light text #ffffff
Link colour #2b4aba
special colour #00044d

it's a slight change so that you see something is new but not to hard

grafik

Beside this I would like to propose to improve the color system at all for 5.2 or so ...

avatar HLeithner
HLeithner - comment - 8 Sep 2023

It's marketing decision now. They will came up with something and we will see what it is.

I have only 3 wishes.

  • change the color, at least another blue so j5 is visually different then j4 at the first glance
  • have the full colored joomla logo somewhere (at the moment it's only on the login screen in the backend so removing it from here means no joomla logo in joomla which feels wrong to me)
  • maybe a (new not j4) pattern on the left site which a "hidden/hard to see on the first look" 5 reference for the version number.

Beside that sticking to the CI/CD Brand manual should be clear.

avatar chmst
chmst - comment - 12 Sep 2023

All backgrounds in white with dark colour- only carefully drawed lines and borders ?

avatar joeforjoomla
joeforjoomla - comment - 12 Sep 2023

It would be useful a quick decision on this matter, as it's time to prepare and release updates of extensions that reflect the new backend color

avatar joeforjoomla
joeforjoomla - comment - 19 Sep 2023

@HLeithner Any update or decision on this matter? We are at Beta 2

avatar HLeithner
HLeithner - comment - 20 Sep 2023

there is a working group for it which will only adapt the color to another blue, no hard changes afaik.

avatar joeforjoomla
joeforjoomla - comment - 20 Sep 2023

Thanks to let me know, any timeline for the new blue color? We have to adapt all our extensions in time for Joomla 5 stable

avatar micker
micker - comment - 20 Sep 2023

@joeforjoomla maybe you can use template css variable of atum => that automatic

avatar HLeithner
HLeithner - comment - 20 Sep 2023

that what @micker says and hopefully by friday but can't promise...

avatar joeforjoomla
joeforjoomla - comment - 20 Sep 2023

I can't use the atum var in all cases... will wait hopefully by friday

avatar joeforjoomla
joeforjoomla - comment - 27 Sep 2023

As we are approaching the RC, is Joomla 5 going to have the same color of Joomla 4 then?

avatar HLeithner HLeithner - change - 28 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-28 20:26:55
Closed_By HLeithner
Labels Added: Feature
avatar HLeithner HLeithner - close - 28 Sep 2023

Add a Comment

Login with GitHub to post a comment