[#41578] - [5.0] Fix, Hide toolbar in modal when it not in use
- Closed
- 5 Sep 2023
- Medium
- Build: 5.0-dev
- # 41578
- Diff
- Fedik:modal-toolbar
User tests: Successful: Unsuccessful:
Pull Request for Issue #41572 .
Summary of Changes
Hide toolbar on empty state, in modal.
Because $this->setLayout('emptystate'); override the layout value the condition if ($this->getLayout() !== 'modal') never work.
Testing Instructions
On installation without articles.
Try select an article for menu. Also Category, Contact, Tags
Also try to add a module to dashboard.
Actual result BEFORE applying this Pull Request
You get a toolbar in modal
Expected result AFTER applying this Pull Request
No toolbar
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
Reference:
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_modules |
| Status | New | ⇒ | Pending |
| Category | Administration com_content com_modules | ⇒ | Administration com_categories com_contact com_content com_modules com_newsfeeds com_tags |
| Labels |
Added:
PR-5.0-dev
|
||
I have tested this item ✅ successfully on 63b034b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.
| Category | Administration com_content com_modules com_categories com_contact com_newsfeeds com_tags | ⇒ | Administration com_categories com_contact com_content com_media com_modules com_newsfeeds com_tags |
| Labels |
Added:
?
bug
|
||
Should be good now also for Media.
Can only re-test "image select" while aricle editing
| Status | Ready to Commit | ⇒ | Pending |
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.
Got 3 different results while testing after an update, trying now on new install (new install fails with Class "Joomla\Plugin\Behaviour\Taggable\Extension\Taggable" not found so updating the branch).
| Labels |
Removed:
?
|
||
Got 3 different results while testing after an update
✅ "New article" uses new ModalField, so it is okay ,
✅ "New contact" uses old ModalField, so it also okay ,
❌ "New newsfeed" uses old ModalField, and it need to fix the toolbar,
Got 3 different results while testing after an update
✅ "New article" uses new ModalField, so it is okay , ✅ "New contact" uses old ModalField, so it also okay , ❌ "New newsfeed" uses old ModalField, and it need to fix the toolbar,
I confirm. Also
✅ "New categories"
Could not find where tags could be created in modal.
newsfeed should be good now
I will set it as Draft for now.
There other related issues, wich need to find a better approach.
| Title |
|
||||||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-05 11:52:59 |
| Closed_By | ⇒ | Fedik |
I have tested this item ✅ successfully on 63b034b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41578.