[#41528] - [5.0] Fix tinyMCE drag and drop images
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41528
- Diff
- dgrammatiko:5.0-dev-tiny-options
- Pending continuous-integration/appveyor/pr Waiting for AppVeyor build to complete Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #41527 .
Summary of Changes
TinyMCE v6 has strict types for the options, now it needs a setter and a getter
Testing Instructions
Try to upload an image
Actual result BEFORE applying this Pull Request
Broken
Expected result AFTER applying this Pull Request
Not broken
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
@brianteeman if you find another such error please tag me
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item ✅ successfully on 7228be4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41528.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41528.
| Labels |
Added:
?
|
||
@brianteeman @Quy I made a mistake, the options should be registered at the plugin level not the main instance of tinyMCE. Also the plugin was transformed to ESM so it can be linted.
If you don't mind please rede your tests (sorry)
| Labels |
Removed:
?
|
||
| Status | Ready to Commit | ⇒ | Pending |
Back to pending
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41528.
I have tested this item ✅ successfully on 2464ad4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41528.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 16:08:44 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested this item ✅ successfully on 7228be4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41528.