[#41523] - [4.4] set_time_limit php 8
- Fixed in Code Base
- 8 Sep 2023
- Medium
- Build: 4.4-dev
- # 41523
- Diff
- brianteeman:set_time_limit
User tests: Successful: Unsuccessful:
Pull Request for Issue #38876 .
Summary of Changes
some hosts disable set_time_limit in php
Prior to PHP 8.0.0, it was possible for the @ operator to disable critical errors that will terminate script execution. For example, prepending @ to a call of a function which did not exist, by being unavailable or mistyped, would cause the script to terminate with no indication as to why.
This PR replaces the @ with a function_exists check
Testing Instructions
code review or in php.ini
disable_functions = set_time_limit
Actual result BEFORE applying this Pull Request
Admin dashboard loads with an error
finder index ends with an error
Expected result AFTER applying this Pull Request
everything works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Libraries |
| Status | New | ⇒ | Pending |
@richard67 I assume it works otherwise we have a problem with the existing use
joomla-cms/administrator/components/com_scheduler/src/Scheduler/Scheduler.php
Lines 134 to 136 in d20c455
I just retested this PR with php 7.4.9 and set_time_limit disabled and no problems
I just retested this PR with php 7.4.9 and set_time_limit disabled and no problems
Ok, thanks for checking.
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 2daf4cf
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41523.
Is there a reason why this PR is made for 4.4-dev and not 4.3-dev? To me it seems to be a bug fix.
No reason
Would be good to get this in the framework file system too if it’s effected but it’s not a hard requirement
@brianteeman are able to add the checks also to the framework package?
i will look at the framework now and do a pr there if needed as well
@wilsonge @laoneo I already did the framework changes last week at the same time I did this joomla-framework/filesystem#59
but it was rubbish so i did itagain joomla-framework/filesystem#60
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 12:17:54 |
| Closed_By | ⇒ | laoneo |
Thanks!
@brianteeman As this PR is for 4.4-dev: Have you checked if it works with PHP 7.4? I'm asking because of this info I get from here https://php.watch/versions/8.0/disable_functions-redeclare , especially the last sentence :
Could you check?