[#41513] - [4.4] Incorrect message for user fields
- Closed
- 21 Nov 2023
- Medium
- Build: 4.3-dev
- # 41513
- Diff
- brianteeman:user-field
User tests: Successful: Unsuccessful:
Alternative for #41435
Summary of Changes
The user profile displays various fields. Some of them have a value, some of them have no value and some of them have no value but that means they use the site default value.
Originally the text was "No information entered" but this wasn't correct for the fields using a default value so I changed the text to "website default" in #25699
That was wrong as I only considered the basic params in a user profile and not any additional fields such as from the user profile plugin or a custom field.
This created a scenario where a users name and address in their profile would be displatyed as "website default" when it should have been blank.
This PR keeps the behaviour on the basic params to display "website default" but removes any default text being used for the other fields as its not appropriate.
Testing Instructions
- Create a user custom field
- Publish the user profile plugin
- Create a menu item to display a user profile
- Log in to the front end and go to the profile page
- Edit the profile by setting some but not all fields
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_users Front End Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
| Title |
|
||||||
| Labels |
Added:
PR-4.4-dev
|
||
@brianteeman
I updated the Test site
For me it is NOT running as expected.
Frontend
For all fields that can be left empty = just to don't show nothing, any value, left it empty.
Are you sure the rule is applying by default also on the Users Joomla Custom Fields ?
I created a Calendar (Birthday) Joomla Custom Field and "Website Default"is still shown.
For all the fields that when not yet setted they redirect to a "site default value" like the "Basic Settings" fields (Time Zone, Frontend Language,...) = just to show the default value and not the written "site default".
Right now also here it is showing nothing as above, instead to show the default value.
So, for example, from:
- Time Zone: Website default
- Frontend Language: Website default
They should be shown directly as:
- Time Zone: UTC-5
- Frontend Language: Spanish
Where "UTC-5" and "Spanish" are the default values.
Do you want Super Admin credentials of the test site ? (Where I can send it to you ?
I have tested this item ✅ successfully on 3db8c0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41513.
| Labels |
Added:
bug
Removed: PR-4.3-dev |
||
Hi @ceford
on Frontend:
A - Are you sure the rule to write nothing is applying by default also on the Users Joomla Custom Fields ?
I tested creating some custom fields and I always have back "Website Default" as value.
B - For all the fields that, when not yet setted, they redirect to a "site default value" like the "Basic Settings" fields (Time Zone, Frontend Language,...), they should just to show the default value and not the written "site default" (or nothing)
Please, Can you reproduce them ?
On A: I added a Textarea field and confirm that if I do not enter any data it appears in the front end without any data. That confirms the Test Pass result.
On B: My test results show what the pull request required. If you think the Time Zone should show the actual time zone rather than Website default perhaps that is a separate issue.
Hi @MacJoom
Okay, I'm going to close the PR #41435
I'm still "stopped" to this point #41435 (comment) (backend/frontend).
For me, Joomla 4.4 frontend, is not running as expected:
A - Are you sure the rule to write nothing is applying by default also on the Users Joomla Custom Fields ?
I tested creating some custom fields and I always have back "Website Default" as value.
B - For all the fields that, when not yet setted, they redirect to a "site default value" like the "Basic Settings" fields (Time Zone, Frontend Language,...), they should just to show the default value and not the written "site default" (or nothing)
Please, Can you reproduce them ?
@brianteeman - can you comment on joomlebs issues? Thank you.
Hi @Quy
A - As far as I understand, what is shown in your image are the fields of the (old) User Profile Joomla plugin.
What I asked is: Are you sure that the rule "to write nothing" is applying by default also on the (new) Users Joomla Custom Fields ?
I tested creating some new custom fields and I always have back "Website Default" as value...
Please, Have you tested it by creating a new Custom Field ?
B - @MacJoom - Please, Are you going to split it? Or, What should I do ?
No issues with custom fields. I did a calendar field as you mentioned in your previous comment.
Before PR, the About Me value is escaped.
| Labels |
Added:
?
|
||
Now no values are displayed except Website field.
isnt that the entire point?
Sorry I should have mentioned that these fields have values but are not displayed.
Closing this for now
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-21 17:09:48 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
Removed: ? |
||
Hi guys,
@brianteeman What do you mean with "closing this for now" ?
I'm asking to know what to do with its alter ego ticket #42377 I opened in November...
rebased to 4.4