[#41489] - [5.0] Content refactoring of testing sampledata
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41489
- Diff
- Hackwar:5.0-sampledata
User tests: Successful: Unsuccessful:
Summary of Changes
The testing sampledata are currently broken in several regards. The text itself is outdated and sometimes references Joomla 2.5 or even 1.5, the modules aren't displayed everywhere and for the frontend views, not all views are listed. This PR tries to clean all of this up. So far the following changes have been made:
1, Add all frontend views of core components
2. Add all frontend views and modules as sub-menu items of their respective component
3. Make all loadmodule occurences work again
4. Remove references to com_search in menus and modules
5. Refactor menu item creation
6. Refactor module assignments to menu items
This should now be more stable against additional changes to the sample content in the future. It still requires a lot of content updates, especially stuff like atomic and beez templates should be removed and replaced with content about Cassiopeia.
Testing Instructions
- Install Joomla
- Apply testing sampledata
- Bask in the glory of this newly sorted testing data. ?
Actual result BEFORE applying this Pull Request
Testing sampledata doesn't work in 5.0
Expected result AFTER applying this Pull Request
Testing sampledata works and is so much cooler than in 4.x
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
Installed and tested - no issues. When clicking through texts, I found some links to very, very outdated docs.
But this is a documentation task not in scope here.
Question: Should we remove all images and then delete the sample data images completely?
'menutype' => $menuTypes[3],
'title' => $this->getApplication()->getLanguage()->_('PLG_SAMPLEDATA_TESTING_SAMPLEDATA_MENUS_ITEM_8_1_TITLE'),
'link' => 'index.php?option=com_content&view=category&layout=blog&id=' . $articleCatids4[5],
'parent_id' => $menuIdsLevel1[8],
'component_id' => ComponentHelper::getComponent('com_content')->id,
articleCatids4[5] is an empty category so another choice should be made
- Make all loadmodule occurences work again
Still seeing quite a few non-working eg Smart Search
I did the basics yesterday. Will fix a few more issues now. I hope that this can be finished by the end of the week.
| Labels |
Added:
PR-5.0-dev
|
||
A deep menu
- set to not display on the using joomla page but i think thats the home page for that menu
- doesnt expand
I did some additional work and would call this ready to be merged. The way it is now, the content shouldn't be entirely broken anymore and changes should be easily incorporated without having to change everything. I would thus hand this over to the documentation team to update the texts. ?
I have tested this item ✅ successfully on ace4e6e
I created a new clone of J5.0-dev, installed the patchtester and applied this patch. Then I installed the Test Sample Data. That worked fine and the site looks fine as I remember it from a previous installation. So the patch is good.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41489.
I have tested this item ✅ successfully on ace4e6e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41489.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41489.
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 20:25:08 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks for doing this. I started a few times but bailed at the size of the task. I will test and comment etc tomorrow.