Feeling Lucky
Feature
PR-5.0-dev
[#41488] - [5.0][Events] Event classes for Actionlog, Cache, Contact, Checkin components
- Fixed in Code Base
- 2 Sep 2023
- Medium
- Build: 5.0-dev
- # 41488
- Diff
- Fedik:event-components
User tests: Successful: Unsuccessful:
Summary of Changes
Event classes for Actionlog, Cache, Contact components
Affected events:
- onAfterLogPurge (Actionlog)
- onAfterLogExport (Actionlog)
- onAfterPurge (Cache)
- onValidateContact (Contact)
- onSubmitContact (Contact)
- onAfterCheckin (Checkin)
Testing Instructions
Use Actionlog, Cache, Contact components. Clean cache, submit contact form, Checkin.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select:
- Documentation link for docs.joomla.org: https://docs.joomla.org/Plugin/Events
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org: joomla/Manual#177
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_cache Front End com_contact Libraries Plugins |
| Status | New | ⇒ | Pending |
| Labels |
Added:
Feature
PR-5.0-dev
|
||
Fedik
- comment
- 28 Aug 2023
I think it is okay, they doing basicaly the same. I would not make it more complicated.
As I see, this event mostly used only for logging.
| Category | Administration com_cache Front End com_contact Libraries Plugins | ⇒ | Administration com_cache com_checkin Front End com_contact Libraries Plugins |
| Title |
|
||||||
HLeithner
- comment
- 2 Sep 2023
Merging this as with code review and based on the other similar PRs, before beta1 to get enough feedback for final release.
Additional, we need to deprecate the referenced arrays, so we can remove the workaround in J 7.0
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-02 14:19:14 |
| Closed_By | ⇒ | HLeithner |
do you think it's good that we have the same event class for purge and purge group?
PurgeGroup could be abstracted from the purge event and add the information (group) as argument?