[#41469] - Filter for special characters that fail sending test mail
- Fixed in Code Base
- 1 Sep 2023
- Medium
- Build: 4.3-dev
- # 41469
- Diff
- MagnusSinger:i41061
User tests: Successful: Unsuccessful:
Pull Request for Issue #41061.
Summary of Changes
When trying to send a test mail from the backend, it now filters the site name so the sending does succeed.
Testing Instructions
Enter a site name containing "@" and/or "|" and try to send a test mail
Actual result BEFORE applying this Pull Request
The mail could not be sent
Expected result AFTER applying this Pull Request
The mail can be sent
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
| Status | New | ⇒ | Pending |
This should contain some comments in the code so that in the future someone will know why the preg_filter has been added
I have tested this item ✅ successfully on 90f94a6
on 4.3.4 - the patch works however i could not reproduce the issue on my system: My sitename is Test|PR@Infotech
before:
Test mail from Test|PR@Infotech (Subject works, all send methods)
after:
Test mail from TestPRInfotech ( | and @ are stripped in the subject for all send methods)
but anyway it just in the testmail...
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-4.3-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.
| Labels |
Added:
?
|
||
| Labels |
Added:
bug
|
||
This should contain some comments in the code so that in the future someone will know why the preg_filter has been added
@brianteeman I added a comment to the file
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-01 22:36:54 |
| Closed_By | ⇒ | obuisard |
Thank you Magnus @MagnusSinger for the PR!
This here breaks the system tests on 4.4 as the site name is always null when none of these special characters are in the string. You can test it here https://onlinephp.io?s=s7EvyCjg5SpLLIpPKc0t0CgoSk2PT8vMKUkt0ohW13fQV9dRUNePqdFXjwUyQJyQ1OISIK1rqKlpDQA%2C&v=8.2.10
I have tested this item ✅ successfully on 90f94a6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41469.