? PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
26 Aug 2023

Pull Request for Issue #40215 .

Summary of Changes

remove duplicate entries which will cause database error
image

Testing Instructions

install dutch language pack

Actual result BEFORE applying this Pull Request

no entries in #__finder_terms_common for dutch language

Expected result AFTER applying this Pull Request

88 entries in #__finder_terms_common for dutch language (v4.3.4.1) in database

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2023
Category Front End Plugins
avatar heelc29 heelc29 - open - 26 Aug 2023
avatar heelc29 heelc29 - change - 26 Aug 2023
Status New Pending
avatar flo-the-cat flo-the-cat - test_item - 26 Aug 2023 - Tested successfully
avatar flo-the-cat
flo-the-cat - comment - 26 Aug 2023

I have tested this item ✅ successfully on 357fa73


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41468.

avatar brianteeman
brianteeman - comment - 27 Aug 2023

While this does resolve the issue surely the correct way is to remove the duplicates at source in the NL language pack

avatar heelc29
heelc29 - comment - 28 Aug 2023

Yes, that's what I've done here joomlagerman/joomla#2661 for the german language pack... so I'm happy with how it is now.

avatar Quy Quy - test_item - 16 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 16 Sep 2023

I have tested this item ✅ successfully on 357fa73


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41468.

avatar Quy Quy - change - 16 Sep 2023
Status Pending Ready to Commit
Labels Added: PR-4.3-dev
avatar Quy
Quy - comment - 16 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41468.

avatar Quy Quy - change - 16 Sep 2023
Labels Added: ?
avatar obuisard obuisard - merge - 19 Sep 2023
avatar obuisard obuisard - change - 19 Sep 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-19 01:00:15
Closed_By obuisard
avatar obuisard obuisard - close - 19 Sep 2023
avatar obuisard
obuisard - comment - 19 Sep 2023

Thank you @heelc29 for the PR!

Add a Comment

Login with GitHub to post a comment