? bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar joomdonation
joomdonation
26 Aug 2023

Pull Request for Issue #41265.

Summary of Changes

This PR fixes the deprecated as described in the issue #41265 . Please look at the issue t understand the actual issue.

Instead of using hardcoded date format, we can set translateformat="true" . It has two benefits:

  • No deprecated warnings anymore
  • The selected date is display in the format controlled by the use language, more friendly than the hardcoded Y-m-d format

Testing Instructions

  1. Use Joomla 5
  2. See #41265 , confirm the issue
  3. Apply patch, confirm the issue fixed, no deprecated warnings anymore

Actual result BEFORE applying this Pull Request

There is deprecated warnings as described in the issue.

Expected result AFTER applying this Pull Request

No warning anymore. The selected date will still being saved properly. If you use a language which is not using Y-m-d format, the selected date will also be displayed in the date format of your language, too.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2023
Category Front End Plugins
avatar joomdonation joomdonation - open - 26 Aug 2023
avatar joomdonation joomdonation - change - 26 Aug 2023
Status New Pending
avatar waader waader - test_item - 26 Aug 2023 - Tested successfully
avatar waader
waader - comment - 26 Aug 2023

I have tested this item ✅ successfully on c36b07b

I could replicate the problem and with this patch it is gone.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41453.

avatar brianteeman brianteeman - test_item - 27 Aug 2023 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 27 Aug 2023

I have tested this item ? unsuccessfully on c36b07b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41453.

avatar brianteeman brianteeman - alter_testresult - 27 Aug 2023 - brianteeman: Tested successfully
avatar brianteeman brianteeman - test_item - 27 Aug 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Aug 2023

I have tested this item ✅ successfully on c36b07b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41453.

avatar brianteeman
brianteeman - comment - 27 Aug 2023

RTC

avatar HLeithner HLeithner - change - 27 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-27 19:01:26
Closed_By HLeithner
Labels Added: ? bug PR-5.0-dev
avatar HLeithner HLeithner - close - 27 Aug 2023
avatar HLeithner HLeithner - merge - 27 Aug 2023
avatar HLeithner
HLeithner - comment - 27 Aug 2023

Thanks

Add a Comment

Login with GitHub to post a comment