[#41452] - [5.0] Handle browser page title properly for article view
- Fixed in Code Base
- 26 Aug 2023
- Medium
- Build: 5.0-dev
- # 41452
- Diff
- joomdonation:fix_browser_page_title_for_article
User tests: Successful: Unsuccessful:
Pull Request for Issue #41372.
Summary of Changes
Currently, if you create a menu item to display an article and leave browser page title parameter empty in the menu item parameters, the system is using display wrong browser page title. Instead of using browser page title set from article (or article title), it uses Title of menu item and it's not right. See #41372 for more more information
I would say that this is a bug fix, but since the issue is marked as new feature, I create a PR to 5.0-branch. Happy to change the PR to 4.3-dev if needed
Testing Instructions
- Uses Joomla 5
- Follow instructions at #41372 , confirm the issue
- Apply patch, confirm that the issue is fixed
Actual result BEFORE applying this Pull Request
Joomla is using menu item title for browser page title of the page
Expected result AFTER applying this Pull Request
Joomla is using the browser page title set for the article and if that information is not set, use Article title
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
Votes
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
@coolcat-creations I don't know why you are getting that error as it is not related to change from this PR. Is it from a fresh latest Joomla 5 installation ?
Anyway, I realized that this is is not a right fix (and not easy to fix, because if page title is not entered for the menu item, Joomla will use menu item title for page title in earlier process). I will have to find a way to handle it.
I am sorry I tested on J4 - my bad - let me check once again
| Labels |
Added:
PR-5.0-dev
|
||
OK. So the last commit should handle it properly. Please test it again. Thanks !
I have tested this item ✅ successfully on d78a15d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41452.
I have tested this item ✅ successfully on d78a15d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41452.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-26 13:07:04 |
| Closed_By | ⇒ | HLeithner |
thanks
I have tested the patch but I get an error "Class "Joomla\CMS\Event\Content\ContentPrepareEvent" not found" on all sites after applying.