? PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
21 Aug 2023

Summary of Changes

set correct license information in header (see also #40400 or #41277 for reference)

Testing Instructions

code review

avatar joomla-cms-bot joomla-cms-bot - change - 21 Aug 2023
Category Libraries
avatar heelc29 heelc29 - open - 21 Aug 2023
avatar heelc29 heelc29 - change - 21 Aug 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 21 Aug 2023

why were these changes not in an upmerge? its a waste of your valuable time to do this

avatar heelc29
heelc29 - comment - 21 Aug 2023

why were these changes not in an upmerge? its a waste of your valuable time to do this

@brianteeman do you mean the other PR #41422?

The "error-pages" (templates/system/build_incomplete.html, templates/system/fatal-error.html, templates/system/incompatible.html) are generated/updated by the translation-bot in PR for translation update (eg. #41137)

npm ci --ignore-scripts && node build/build.js --build-pages

and this is (at the moment) only available for 4.3-dev.

gh pr list -R joomla/joomla-cms --state open --author joomla-translation-bot -S "Translation Update" | grep -v "No pull" || \
gh pr create --title "Translation Update" --body "Automatically created pull request based on core-translation repository changes" -R joomla/joomla-cms --base 4.3-dev

So only the 3 files were updated in 4.3-dev (and upmerged).

The 4th file is only available in 5.0-dev (added with #40509) and do not exist in prior versions (no upmerge possible)

"destFile": ["/templates/system/incompatible.html", "/includes/incompatible.html"]

The solutions would be

  • run npm ci in the upmerge PR
  • or create an second/new workflow for translation update v5 (if crowdin is ready)

to to this automatically...

avatar brianteeman brianteeman - test_item - 21 Aug 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Aug 2023

I have tested this item ✅ successfully on e7c4629


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41423.

avatar richard67 richard67 - test_item - 22 Aug 2023 - Tested successfully
avatar richard67
richard67 - comment - 22 Aug 2023

I have tested this item ✅ successfully on e7c4629


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41423.

avatar richard67 richard67 - change - 22 Aug 2023
Status Pending Ready to Commit
Labels Added: PR-5.0-dev
avatar richard67
richard67 - comment - 22 Aug 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41423.

avatar HLeithner HLeithner - change - 22 Aug 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-22 07:39:42
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 22 Aug 2023
avatar HLeithner HLeithner - merge - 22 Aug 2023
avatar HLeithner
HLeithner - comment - 22 Aug 2023

thanks

Add a Comment

Login with GitHub to post a comment