Feeling Lucky
PR-5.0-dev
[#41422] - [5.0] Update incompatible.html
- Closed
- 22 Aug 2023
- Medium
- Build: 5.0-dev
- # 41422
- Diff
- heelc29:5.0/template-incompatible
User tests: Successful: Unsuccessful:
Summary of Changes
update includes/incompatible.html
file was not updated with #41410; since #40509 (comment) there is a new file
please take care of it in the next upmerge (after translation update) @HLeithner @laoneo
Testing Instructions
run npm ci
Actual result BEFORE applying this Pull Request
1 versioned file is modified
Expected result AFTER applying this Pull Request
no file is modified
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
heelc29
- comment
- 21 Aug 2023
don't the build scripts automatically handle these?
Yes, but not with an upmerge because the file do not exist in 4.4-dev
richard67
- comment
- 22 Aug 2023
I have tested this item ✅ successfully on eb198cb
Hint for other testers:
- You can fetch the changes from this PR with git commands
git fetch upstream pull/41422/head:test-pr-41422and thengit checkout test-pr-41422. - After
composer installandnpm ci, use git commandgit statusto see if there are some changes to be committed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41422.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-22 08:58:51 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-5.0-dev
|
||
HLeithner
- comment
- 22 Aug 2023
I'm closing this, it will be automatically be done with language update. thanks anyway.
don't the build scripts automatically handle these?