Feature PR-5.0-dev ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
7 Aug 2023

Summary of Changes

Set JSON flags for rendering slashes and unicode, and debugging.
For script options and schema.org

Testing Instructions

Apply patch,
Check source code of any page.
Script options should be rendered without escaped slashes.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2023
Category Libraries Modules Front End Plugins
avatar Fedik Fedik - open - 7 Aug 2023
avatar Fedik Fedik - change - 7 Aug 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 7 Aug 2023

Maybe adding an Option to the render it self could be more useful for more places and otherer renders like XML?

avatar Fedik
Fedik - comment - 7 Aug 2023

I not very imagine how it can work.
There really nothing for the option.

If you mean Registry renderer, they already have an options variable, for renderer.

avatar heelc29
heelc29 - comment - 7 Aug 2023
avatar Fedik
Fedik - comment - 7 Aug 2023

@heelc29 I did not seen that, sorry

avatar joomla-cms-bot joomla-cms-bot - change - 7 Aug 2023
Category Libraries Modules Front End Plugins Libraries
avatar Fedik Fedik - change - 7 Aug 2023
Labels Added: Feature PR-5.0-dev ?
avatar Fedik Fedik - change - 7 Aug 2023
The description was changed
avatar Fedik Fedik - edited - 7 Aug 2023
avatar Fedik
Fedik - comment - 7 Aug 2023

I have removed schema from this PR

avatar HLeithner
HLeithner - comment - 7 Aug 2023

Add a 'debug' option to the registry formatter and passthru the JDEBUG constant to the formatter.

In the formatter query the paramtrr and set the relevant json encode options.

Maybe for all other formatters where it make sense too

avatar HLeithner
HLeithner - comment - 7 Aug 2023

Or maybe call the option prettify

avatar Fedik
Fedik - comment - 7 Aug 2023

I think it is to much, it need only in 1-2 places

avatar HLeithner
HLeithner - comment - 7 Aug 2023

Don't think so prettify is needed often. At least I use it regularly for development and in some cases where comparison is needed. But maybe it's only me

avatar Quy Quy - test_item - 13 Aug 2023 - Tested successfully
avatar Quy
Quy - comment - 13 Aug 2023

I have tested this item successfully on 4588945


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41330.

avatar HLeithner HLeithner - close - 14 Aug 2023
avatar HLeithner HLeithner - merge - 14 Aug 2023
avatar HLeithner HLeithner - change - 14 Aug 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-08-14 07:42:22
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 14 Aug 2023

Since it seems I'm the only one that wants a standard way to have well formated output for the registries, I'm merging this and close the topic for me.

thanks

Add a Comment

Login with GitHub to post a comment