[#41329] - [4.3] Content Archive a11y
- Fixed in Code Base
- 7 Aug 2023
- Medium
- Build: 4.3-dev
- # 41329
- Diff
- brianteeman:archive-a11y
User tests: Successful: Unsuccessful:
Summary of Changes
Every fieldset must have a legend
Every input/select must have a label
thanks to @wilsonge for spotting this
Testing Instructions
Create a menutype for archive articles
In the Archive tab set the Filter Field to show
Display the menu in the front end
Existing language strings have been used so there is no translation required
Expected result BEFORE applying this Pull Request
Visually there is a small change as there is now a gab between the title and filter rows
Non-visually there is now a legend and labels for all the selects
Passes accessibility tests
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | New | ⇒ | Pending |
| Labels |
Added:
PR-4.3-dev
|
||
Can be tested with the built-in accessibility check of Firefox developer tools. Before applying the PR there are also errors about missing labels, after applying the PR only a contrast issue is remaining. Markup inspection looks right, too. The "for" of the labels fits to the IDs of the selects.
P.S.: Testing sample data can be used on a development version to get the archived article and the menu item. It just needs to set the filter to be shown as described in the instructions.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-07 17:09:36 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
bug
|
||
Thank you Brian @brianteeman for the PR.
I have tested this item✅ successfully on 41811b4
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41329.