Feeling Lucky
?
PR-4.4-dev
[#41293] - [4.4] api tests banner
- Fixed in Code Base
- 9 Aug 2023
- Medium
- Build: 4.4-dev
- # 41293
- Diff
- heelc29:4.4/test/api/banners
User tests: Successful: Unsuccessful:
Summary of Changes
API tests for following endpoints:
- GET: v1/banners/:id
- GET: v1/banners/clients
- GET: v1/banners/clients/:id
- POST: v1/banners/clients
- PATCH: v1/banners/clients/:id
- DELETE: v1/banners/clients/:id
- GET: v1/banners/categories
- GET: v1/banners/categories/:id
- POST: v1/banners/categories
- PATCH: v1/banners/categories/:id
missing:
asset:
- DELETE: v1/banners/categories/:id
history:
- GET: v1/banners/:id/contenthistory
- PATCH: v1/banners/:id/contenthistory/keep
- DELETE: v1/banners/:id/contenthistory
Testing Instructions
code review; drone execute test
joomla-cms-bot
- | Category | ⇒ | JavaScript Unit Tests |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-4.4-dev
|
||
heelc29
- comment
- 8 Aug 2023
Some endpoints are missing ...
Delete category: fails because no asset item is created when insert category direct in database
History: fails because history is not created when insert category direct in database
Maybe an option is an combined test: create and delete category ...
If the pr is already ok then it will be ready to merge
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-09 08:39:00 |
| Closed_By | ⇒ | laoneo |
laoneo
- comment
- 9 Aug 2023
Thanks!
Pr is looking good and drone is happy too, can we merge it?