I see two specific issues

1. Everything is a link. A link should tell me what to expect when I follow the link. Currently it just has the name of the module etc. Maybe this can be improved by adding some sr-only text.

Changing

<li>
<a href="/administrator/index.php?option=com_templates&amp;view=template&amp;task=template.overrides&amp;folder=QzpcbGFyYWdvblx3d3dcajVcbW9kdWxlc1xtb2RfYXJ0aWNsZXNfYXJjaGl2ZQ==&amp;id=227&amp;file=aG9tZQ&amp;isMedia=0&amp;73ad755ad588508ed1c15e0b4f5e80c3=1">
<span class="icon-copy" aria-hidden="true"></span>
&nbsp;mod_articles_archive</a>
</li>

To

<li>
<a href="/administrator/index.php?option=com_templates&amp;view=template&amp;task=template.overrides&amp;folder=QzpcbGFyYWdvblx3d3dcajVcbW9kdWxlc1xtb2RfYXJ0aWNsZXNfYXJjaGl2ZQ==&amp;id=227&amp;file=aG9tZQ&amp;isMedia=0&amp;73ad755ad588508ed1c15e0b4f5e80c3=1">
<span class="icon-copy" aria-hidden="true"></span>
<span class="sr-only">Create override</span> 
&nbsp;mod_articles_archive</a>
</li>

2. When the link is to simply open the tree then it should not be a link as its doing something and not going somewhere. The treeview pattern should gelp there.

@brianteeman

Thanks for looking into this.

One more small item I noticed was the home menu disappears from the main menu:

whatever that is will be unrelated - so please could you open a new issue with that explaining exactly when the home menu icon disappears from a site menu

@brianteeman thanks for your reply. Your proposal looks good to me. I still feel it has some UX issues, but that's for another issue.

The only thing I think we should give a spin is to the translation of the sr-only text. In the few languages I know, the grammatical structure "Create override + NAME" works fine, but maybe it would be interesting to offer a way for languages with different grammar rules?

Create override + NAME"

I would make it a sprintf "Create overide %1" so that resolves that issue

@brianteeman but then we need to include the span and the sr-only class in the translation, don't we? Or we duplicate the name of the element to override?

@brianteeman but then we need to include the span and the sr-only class in the translation, don't we? Or we duplicate the name of the element to override?

yes it would appear so. even if we only fix that part now and leave the tree accessibility to another day this will be an improvement