[#41254] - [5.0][RFC] Move Toolbar singleton to HtmlDocument
- Fixed in Code Base
- 20 Aug 2023
- Medium
- Build: 5.0-dev
- # 41254
- Diff
- HLeithner:5.0/feature/document-toolbar
User tests: Successful: Unsuccessful:
This removes the usage of instances in the Toolbar Class and moves it to HtmlDocument.
Conceptional feedback would be helpful.
Summary of Changes
The reason moving is mainly because the HtmlDocument is everywhere where we need the toolbar and the toolbar is only relevant to the HtmlDocument.
Testing Instructions
For the moment only the smart search indexer has been
changed to use the new getToolbar function. But all other
toolbars also use the HtmlDocument thru the Toolbar::getInstance()
method.
Actual result BEFORE applying this Pull Request
toolbars are working
Expected result AFTER applying this Pull Request
toolbars still working
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
?
PR-5.0-dev
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41254.
| Category | Administration com_finder Libraries | ⇒ | Administration com_finder Language & Strings Modules Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-08-20 20:44:59 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Language Change
|
||
Merging this to get more real live testing in next alpha and pbf
Additional I was wondering about the rtl stuff and the arrow-left / arrow-right thing and if it is a good idea to do this in php. I think it would be better to move this to css and add direction aware icon for such cases like the back button.