Language Change PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Jul 2023

Display the params correctly

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2023
Category Front End Plugins
avatar brianteeman brianteeman - open - 23 Jul 2023
avatar brianteeman brianteeman - change - 23 Jul 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 24 Jul 2023

There is actually a reason why no = green, it's the better state but I understand that it is confusing.

avatar brianteeman
brianteeman - comment - 24 Jul 2023

There is actually a reason why no = green, it's the better state but I understand that it is confusing.

In which case I would suggest that yes/no are the wrong terms to use

avatar HLeithner
HLeithner - comment - 24 Jul 2023

hmm, what would be a better suggestion?

active / disabled?

or a selectbox?

avatar brianteeman
brianteeman - comment - 24 Jul 2023

There are two different things. What is the state and what is the recommendation.

I would probably go for enabled/disabled for the label and update the description string to explain the recommended state. Of course when you could actually see the descriptions without the stupid button it was much easier.

From what I understand you were using the color green to indicate the recommendation? That was an accessibility failure as you shouldnt use color alone

avatar HLeithner
HLeithner - comment - 24 Jul 2023

I'm happy for any improvement.
Description could (always) be something like:

If you use extensions which are not using the latest Joomla Coding standard they might need this setting to work.

or

If the website uses extensions which needs the legacy layer to work they might need this settings to work.

don't know if any of this is good or bad. But Explaining to the end user where the problem is is pretty useless I think since he or she can't fix it anyway. But can the developer "Hey your extension needs this b/c plugin can you bring it uptodate?"

avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2023
Category Front End Plugins Administration Language & Strings Front End Plugins
avatar brianteeman brianteeman - change - 24 Jul 2023
Labels Added: PR-5.0-dev
avatar brianteeman brianteeman - change - 24 Jul 2023
Labels Added: Language Change
avatar brianteeman
brianteeman - comment - 24 Jul 2023

I have updated the description of the plugin instead of the description of the options.

image

avatar brianteeman
brianteeman - comment - 24 Jul 2023

@wilsonge any comments on the changed strings

avatar ghazal
ghazal - comment - 24 Jul 2023

I have updated the description of the plugin instead of the description of the options.

image

+1

avatar HLeithner HLeithner - change - 24 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-24 19:03:11
Closed_By HLeithner
avatar HLeithner HLeithner - close - 24 Jul 2023
avatar HLeithner HLeithner - merge - 24 Jul 2023
avatar HLeithner
HLeithner - comment - 24 Jul 2023

thanks

avatar brianteeman
brianteeman - comment - 24 Jul 2023

thank you

Add a Comment

Login with GitHub to post a comment