PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar heelc29
heelc29
23 Jul 2023

Summary of Changes

  1. Apply the changes from installation/includes/app.php of #36499 also for cli installation/includes/cli.php
  2. Apply the changes from installation/src/Application/InstallationApplication.php of #40664 also for cli installation/src/Application/CliInstallationApplication.php

Testing Instructions

run php installation/joomla.php

Actual result BEFORE applying this Pull Request

image

image

Expected result AFTER applying this Pull Request

image

image

avatar joomla-cms-bot joomla-cms-bot - change - 23 Jul 2023
Category Installation
avatar heelc29 heelc29 - open - 23 Jul 2023
avatar heelc29 heelc29 - change - 23 Jul 2023
Status New Pending
avatar HLeithner
HLeithner - comment - 23 Jul 2023

@wilsonge that was not expected or?

avatar heelc29
heelc29 - comment - 23 Jul 2023

The PR for "cli installation" #38325 have been merged in october 2022 and the pr for "rework session/application" is last updated in june 2022...

avatar heelc29 heelc29 - change - 23 Jul 2023
The description was changed
avatar heelc29 heelc29 - edited - 23 Jul 2023
avatar heelc29 heelc29 - change - 23 Jul 2023
Labels Added: PR-5.0-dev
avatar heelc29
heelc29 - comment - 23 Jul 2023

@HLeithner I also found another bug that interrupts the installation (has something to do with the compat plugin pr)

avatar heelc29
heelc29 - comment - 23 Jul 2023

Since the API system tests were also moved to cypress in 4.4, there is no longer a "test" for the cli installation ?

avatar wilsonge
wilsonge - comment - 24 Jul 2023

Yeah as @heelc29 says. CLI came along after my PR and i didn't even think about it when rebasing.

avatar HLeithner HLeithner - change - 24 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-24 06:13:39
Closed_By HLeithner
avatar HLeithner HLeithner - close - 24 Jul 2023
avatar HLeithner HLeithner - merge - 24 Jul 2023
avatar HLeithner
HLeithner - comment - 24 Jul 2023

thanks

Add a Comment

Login with GitHub to post a comment