PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
18 Jul 2023

Pull Request for #38149 (comment) .

Summary of Changes

With PR #38149 , update SQL scripts have been added, which add a new column to a table.

However, the corresponding SQL statement is missing the /** CAN FAIL **/ installer hint, which has been implemented once with PR #36506 and established with PR #37156 for all ALTER TABLE ... ADD COLUMN statements.

The use of this installer hint is to ignore the SQL error which happens when the statement runs and the column already exists because MySQL and PostgreSQL do not support an IF NOT EXISTS in such an SQL statement. This can happen e.g. when an update breaks for some reason after the SQL statement has run but the schema version has not been updated in the database, so then trying to resume the broken update the statement will run again.

Testing Instructions

Code review. See e.g. following places for examples how /** CAN FAIL **/ is used:

Actual result BEFORE applying this Pull Request

Installer hint /** CAN FAIL **/ is missing.

Expected result AFTER applying this Pull Request

Installer hint /** CAN FAIL **/ is present.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2023
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - open - 18 Jul 2023
avatar richard67 richard67 - change - 18 Jul 2023
Status New Pending
avatar HLeithner HLeithner - change - 18 Jul 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-07-18 11:50:36
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 18 Jul 2023
avatar HLeithner HLeithner - merge - 18 Jul 2023
avatar HLeithner
HLeithner - comment - 18 Jul 2023

thx

avatar brianteeman
brianteeman - comment - 18 Jul 2023

That was my fault for not understanding the meaning of CAN FAIL

avatar richard67
richard67 - comment - 18 Jul 2023

That was fast ? .

Add a Comment

Login with GitHub to post a comment