No Code Attached Yet bug PR-5.0-dev
avatar Fedik
Fedik
18 Jul 2023

When user decide to update the site via FTP, he/she will get a blocked backend.
That because #38149 add new column to DB __menu_types, but DB Fixer will not be accesible due to crash of menu rendering.

We need to find way to avoid such situation.

avatar Fedik Fedik - open - 18 Jul 2023
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Jul 2023
avatar Fedik Fedik - change - 18 Jul 2023
Labels Added: bug PR-5.0-dev
avatar Fedik Fedik - labeled - 18 Jul 2023
avatar Fedik Fedik - labeled - 18 Jul 2023
avatar HLeithner HLeithner - change - 18 Jul 2023
Status New Closed
Closed_Date 0000-00-00 00:00:00 2023-07-18 09:16:26
Closed_By HLeithner
avatar HLeithner HLeithner - close - 18 Jul 2023
avatar HLeithner
HLeithner - comment - 18 Jul 2023

We don't support update with ftp since joomla 1.x or 2.x? don't know but it's not a supported upgrade path at least since joomla 3.

I'm closing this but thanks for looking.

avatar Fedik
Fedik - comment - 18 Jul 2023

Well, at least I warned :)

We already had such issue when auto update failed, and backend was locked, due to unfinished DB update.
User will not be able to recovery esialy.

It not a question if we support or not. I wrote about FTP as quick example.

avatar HLeithner
HLeithner - comment - 18 Jul 2023

That's a problem we can't fix with our current way of upgrading. Needs some rewrite of the update to detect failures. Maybe with checkpoints or something. But in such cases use the backup or apply the schema update manually should be enough. Ymmv

avatar Fedik
Fedik - comment - 18 Jul 2023

This is a module, and I think about wrap ModuleRenderer->render() it in to try/catch.
I had this idea for long time. In some cases It is also cause a broken rendering on the site: half normal page with another half is error page.

In oposite to plugins that hard to try/catch, the module's try/catch should be okay. What do you think?

Add a Comment

Login with GitHub to post a comment